feat: implements usage of insert to toggle between modes (as per #1787)
#2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! What conflicts? With the ?w=1 url parameter it could be checked that the only modifications was those which you made: https://github.com/VSCodeVim/Vim/pull/2295/files?w=1 |
|
I don't remember what the conflicts were. As mentioned in my CR comment, I shouldn't need to use that |
jpoon
changed the title
insert as per #1787
jpoon
changed the title
insert as per #1787insert to toggle between modes (as per #1787)
jpoon
force-pushed
the
insert-key
branch
5 times, most recently
from
f4c0e29
to
e6171d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Continuation of #2295. Haven't heard back from @gibranrosa, and so creating a new PR with his changes.
Which issue(s) this PR fixes. #1787
Special notes for your reviewer: Don't have an
insertkey on my keyboard to test.