1.74 Intentionally Breaks Monkeypatch + CustomizeUI #1390

shellscape · 2023-01-26T01:11:39Z

Describe the bug

A microsoft employee merged a build change that effectively targets and breaks Monkeypatch and CustomizeUI. See: microsoft/vscode#166126. This was a purposeful and malicious commit to further control users of the app.

Please confirm that this problem is VSCodium-specific

This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

Please confirm that the issue/resolution isn't already documented

I checked the Docs page and my issue is not mentioned there.

To Reproduce
Steps to reproduce the behavior:

Install 1.74
Install Monkeypatch
Exit
Run code --verbose from the terminal, or try to start VSCodium from the applications menu

Expected behavior

I was half expecting the project not to pick up malicious changes from MS like this. But it's understandable that this went under the radar.

I would love to see this change excluded, as I view this kind of this as harmful as the telemetry.

Screenshots

n/a

Desktop (please complete the following information):

OS: MacOS
Architecture x64
Version 1.74
App Manager n/a
Sandboxed no

Additional context

Here's the stack that code produces, which is identical to the stack that vscodium produces:

→ code --verbose
[58028:0125/195311.492768:ERROR:node_bindings.cc(289)] Most NODE_OPTIONs are not supported in packaged apps. See documentation for more details.
Loading monkey-patch
(node:58028) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'crypto')
    at P (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:25:24056)
    at i (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:25:33504)
    at get mainIPCHandle (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:32:6945)
    at p.<computed> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:3:53298)
    at Oe.c (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:7310)
    at Oe.b (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:5809)
    at Oe.a (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:4864)
    at Oe.main (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:4709)
    at Object.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:85:1732)
    at s._safeInvokeFunction (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1337)
    at s._invokeFactory (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1522)
    at s.complete (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1801)
    at s._onModuleComplete (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1112)
    at s._onModuleComplete (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1358)
    at s._resolve (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:510)
    at s.defineModule (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:6066)
    at n (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:10527)
    at Object.R (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:6036)
    at s._safeInvokeFunction (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1337)
    at s._invokeFactory (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1522)
    at s.complete (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1801)
    at s._onModuleComplete (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1112)
    at s._onModuleComplete (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1358)
    at s._resolve (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:510)
    at s.defineModule (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:6066)
    at y (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1825)
    at h (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:2554)
    at Object.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.nls.js:3:61)
    at e._createAndEvalScript (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:2598)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:2237
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js:82:14
    at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3)
(Use `Electron --trace-warnings ...` to show where the warning was created)
(node:58028) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

The text was updated successfully, but these errors were encountered:

trvswgnr · 2023-01-26T04:46:17Z

I really hope this project pushes back on PRs like the one causing this issue. It shows an egregious disregard for the community as a whole.

daiyam · 2023-01-26T08:02:59Z

We might disable the mangle since it also breaking the build process on Windows... I have to think about that.

shellscape · 2023-01-26T12:38:40Z

@daiyam that would be wonderful. thanks for taking a look

battaglia01 · 2023-01-27T02:00:40Z

@daiyam yes, please do. Thanks.

daiyam · 2023-01-29T18:23:55Z

OK, I've removed the mangle in the latest Insiders version. Can you test it?

shellscape · 2023-01-29T18:27:31Z

I will be able to test this evening

owenfiscus · 2023-01-29T21:02:16Z

Monkey Patch and / or Customize UI do not appear to function with this release.

If there is an area that I can provide logs from to help the team please let me know and I'll be happy to share.

Thanks!

daiyam · 2023-01-29T22:33:35Z

Ya, it seems that Monkey Patch hasn't been updated since it's impossible to maintain for the official version due to the mangling (iocave/customize-ui#156).
it looks for vs/code/electron-browser/workbench/workbench.html which isn't there anymore (iocave/monkey-patch#61).
I will keep VSCodium not-mangled so you can ask the extensions author to support VSCodium or make your own version.

lehni · 2023-01-31T23:01:43Z

Great news! I used the vsce package command to build a VSIX version of the extension, and with this, both iocave/monkey-patch and iocave/customize-ui work as intended with the latest VSCodium Insider, see attached screenshot!

You can download the extension here:
monkey-patch-0.1.23.vsix.zip

To install, simply run the command: Extensions: Install from VSIX…

Enjoy!

daiyam · 2023-01-31T23:10:02Z

Ya, the git is 2 weeks old while the extension is 3 months old (on VSMarket), 9 months old (on OpenVSX)...

weaming · 2023-02-21T06:12:26Z

@lehni

You can download the extension here: monkey-patch-0.1.23.vsix.zip

To install, simply run the command: Extensions: Install from VSIX…

It shows after started:

Cannot activate the 'Customize UI' extension because it depends on the 'Monkey Patch' extension, which is not installed. Would you like to install the extension and reload the window?

Then I click "Install and Reload", it shows up still.

lehni · 2023-02-21T10:36:55Z

@weaming check your extensions. If you don't see Monkey Patch then you didn't install it correctly. Customize UI needs both extensions to run, and only the custom monkey-patch-0.1.23.vsix.zip above will work on VSCodium v1.75

weaming · 2023-02-22T02:48:11Z

@weaming check your extensions. If you don't see Monkey Patch then you didn't install it correctly. Customize UI needs both extensions to run, and only the custom monkey-patch-0.1.23.vsix.zip above will work on VSCodium v1.75

I reinstall them from vsix file (monkey patch) and MS market (custom UI), but my settings seem do not work as expect as before in VSCode.

Expect:

samyakbardiya · 2023-02-27T06:02:56Z

@weaming: but my settings seem do not work as expect as before in VSCode.

have you re-applied "Enable Monkey Patch" ??

weaming · 2023-02-27T06:50:31Z

@weaming: but my settings seem do not work as expect as before in VSCode.

have you re-applied "Enable Monkey Patch" ??

It works after re-applied, tks!

zwmmm · 2023-03-26T13:27:05Z

re-applied

vscode@1.76 not work

ghost · 2023-03-30T04:26:25Z

vscode@1.76 not work

@zwmmm it works solely on vscodium

Xelbayria · 2023-04-10T03:32:39Z

it seems that there have been no updates for the extensions and VSCodium have been updated to the latest: 1.77.1.23095
It doesn't work with the extensions. Currently, the version is v1.76.2.23074 and it work with the extension.

binaryben · 2023-04-10T04:55:43Z

it seems that there have been no updates for the extensions and VSCodium have been updated to the latest: 1.77.1.23095

Ah good, I thought it was just me. It's stopped working on v1.77 for me as well. I had to disable it to get going and had planned to investigate later, thinking I had accidentally changed something to break it.

Xelbayria · 2023-04-10T06:03:38Z

Ah good, I thought it was just me. It's stopped working on v1.77 for me as well. I had to disable it to get going and had planned to investigate later, thinking I had accidentally changed something to break it.

That's exactly why i had to post that "post" to let everyone know what's going on with the extension and the latest version. I am glad that you know you are not alone.

lehni · 2023-04-11T13:40:48Z

I've fixed this bug in lehni/customize-ui@215ea7f and you can download a new version of the extension to install from a VSIX file here: iocave/customize-ui#170 (comment)

Enjoy!

daiyam · 2023-04-11T14:54:54Z

@lehni If you generate a release in github, users could use VSIX Manager with the following settings to install and keep it up to date.

{
    "vsix.extensions": [
        "github:iocave/customize-ui",
    ],
    "vsix.crons": {
        "update": "0 12 * * *"      // at 12PM, every day
    },
}

drcika · 2023-06-18T08:03:23Z

they did it again
1.80.0-insider
mangles all exports

daiyam · 2023-06-18T08:23:28Z

I will look into it when fixing the patchs for the insiders version

ppnoufal · 2023-07-25T03:47:51Z

Will the patch work with 1.79?

Xelbayria · 2023-07-25T03:58:42Z

Will the patch work with 1.79?

if you are talking about VSCodium, then yes. and i am also using v1.80... it's working fine. Both monkeypatch + CustomizeUI will not work on VSCode.

ppnoufal · 2023-07-25T04:55:04Z

Many thanks, it's working..!!

lehni · 2023-07-25T09:25:55Z

@Kaku-dev see here for a more future-proof way forward: drcika/apc-extension#52 (comment)

wtf403 · 2023-10-12T01:19:53Z

Has anyone manage to get this running in the 1.83 release?

ghost · 2023-10-12T02:11:51Z

@wtf403 Yes. Check out apc-extension

github-actions · 2024-04-10T01:26:38Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!

github-actions · 2024-05-10T01:29:43Z

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue, please open a new issue.

shellscape · 2024-05-10T01:34:24Z

Use Zed. Free yourself from the tyranny.

shellscape added the bug Something isn't working label Jan 26, 2023

shellscape mentioned this issue Jan 27, 2023

Annoucement: Customize UI is probably not going to work anymore iocave/customize-ui#156

Open

battaglia01 mentioned this issue Jan 29, 2023

VSCodium has removed mangling; update to support latest version iocave/customize-ui#162

Open

daiyam mentioned this issue Jan 29, 2023

most extensions aren't loaded any more (vscodium 1.74) jeanp413/open-remote-ssh#44

Closed

trvswgnr mentioned this issue Jan 31, 2023

Monkey path not loading in VSCode 1.74.0 iocave/monkey-patch#55

Open

lehni mentioned this issue Jan 31, 2023

Unable to enable monkey patch due to a missing file iocave/monkey-patch#61

Open

t-fritsch mentioned this issue Feb 4, 2023

Publish On open-vsx.org firefox-devtools/vscode-firefox-debug#214

Open

ghost mentioned this issue Mar 31, 2023

Broke with VS Codium 1.77.0.23090 iocave/customize-ui#170

Closed

github-actions bot added the stale label Apr 10, 2024

github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024

VSCodium locked as off-topic and limited conversation to collaborators May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.74 Intentionally Breaks Monkeypatch + CustomizeUI #1390

1.74 Intentionally Breaks Monkeypatch + CustomizeUI #1390

shellscape commented Jan 26, 2023

trvswgnr commented Jan 26, 2023

daiyam commented Jan 26, 2023

shellscape commented Jan 26, 2023

battaglia01 commented Jan 27, 2023

daiyam commented Jan 29, 2023

shellscape commented Jan 29, 2023

owenfiscus commented Jan 29, 2023

daiyam commented Jan 29, 2023

lehni commented Jan 31, 2023 •

edited

Loading

daiyam commented Jan 31, 2023

weaming commented Feb 21, 2023

lehni commented Feb 21, 2023

weaming commented Feb 22, 2023 •

edited

Loading

samyakbardiya commented Feb 27, 2023

weaming commented Feb 27, 2023

zwmmm commented Mar 26, 2023

ghost commented Mar 30, 2023

Xelbayria commented Apr 10, 2023

binaryben commented Apr 10, 2023 •

edited

Loading

Xelbayria commented Apr 10, 2023

lehni commented Apr 11, 2023

daiyam commented Apr 11, 2023

drcika commented Jun 18, 2023

daiyam commented Jun 18, 2023

ppnoufal commented Jul 25, 2023

Xelbayria commented Jul 25, 2023 •

edited

Loading

ppnoufal commented Jul 25, 2023

lehni commented Jul 25, 2023

wtf403 commented Oct 12, 2023

ghost commented Oct 12, 2023

github-actions bot commented Apr 10, 2024

github-actions bot commented May 10, 2024

shellscape commented May 10, 2024

1.74 Intentionally Breaks Monkeypatch + CustomizeUI #1390

1.74 Intentionally Breaks Monkeypatch + CustomizeUI #1390

Comments

shellscape commented Jan 26, 2023

trvswgnr commented Jan 26, 2023

daiyam commented Jan 26, 2023

shellscape commented Jan 26, 2023

battaglia01 commented Jan 27, 2023

daiyam commented Jan 29, 2023

shellscape commented Jan 29, 2023

owenfiscus commented Jan 29, 2023

daiyam commented Jan 29, 2023

lehni commented Jan 31, 2023 • edited Loading

daiyam commented Jan 31, 2023

weaming commented Feb 21, 2023

lehni commented Feb 21, 2023

weaming commented Feb 22, 2023 • edited Loading

samyakbardiya commented Feb 27, 2023

weaming commented Feb 27, 2023

zwmmm commented Mar 26, 2023

ghost commented Mar 30, 2023

Xelbayria commented Apr 10, 2023

binaryben commented Apr 10, 2023 • edited Loading

Xelbayria commented Apr 10, 2023

lehni commented Apr 11, 2023

daiyam commented Apr 11, 2023

drcika commented Jun 18, 2023

daiyam commented Jun 18, 2023

ppnoufal commented Jul 25, 2023

Xelbayria commented Jul 25, 2023 • edited Loading

ppnoufal commented Jul 25, 2023

lehni commented Jul 25, 2023

wtf403 commented Oct 12, 2023

ghost commented Oct 12, 2023

github-actions bot commented Apr 10, 2024

github-actions bot commented May 10, 2024

shellscape commented May 10, 2024

lehni commented Jan 31, 2023 •

edited

Loading

weaming commented Feb 22, 2023 •

edited

Loading

binaryben commented Apr 10, 2023 •

edited

Loading

Xelbayria commented Jul 25, 2023 •

edited

Loading