Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

Broke with VS Codium 1.77.0.23090 #170

Closed
andreiborisov opened this issue Mar 31, 2023 · 14 comments
Closed

Broke with VS Codium 1.77.0.23090 #170

andreiborisov opened this issue Mar 31, 2023 · 14 comments

Comments

@andreiborisov
Copy link

andreiborisov commented Mar 31, 2023

The custom build of Monkey patch seems to work still, but Customize UI settings no longer change anything in the UI.

@ghost
Copy link

ghost commented Mar 31, 2023

Same here. @daiyam Is it mangled again?
@knopp @lehni please look into this.

@daiyam
Copy link

daiyam commented Mar 31, 2023

The Insiders version was fine so far. I've haven't check on that build. (about the mangling)

Edit: I've checked, VSCodium 1.77.0 isn't mangled.

@lehni
Copy link

lehni commented Apr 1, 2023

I don't have time right now to look into this but will check later next week. I did see that it's not entirely broken, some features of CustomizeUI do get applied. I also saw an error in the console. I'd imagine it's just that CSS / JS has changed and the patch doesn't have the same effect anymore. I'm not a maintainer of CustomizeUI and am not familiar with its internals.

lehni added a commit to lehni/customize-ui that referenced this issue Apr 11, 2023
@lehni
Copy link

lehni commented Apr 11, 2023

I've debugged and fixed this now. For now I'll just recommend installing the extensions from the attached VSIX files. Perhaps I'll decide to keep a fork of monkey-patch and customize-ui maintained under a new namespace, just for VSCodium, we shall see. Enjoy!

customize-ui-0.2.0.vsix.zip
monkey-patch-0.2.0.vsix.zip

@lehni
Copy link

lehni commented Apr 11, 2023

To avoid confusion, I've updated the version numbers to the next minor version.

@andreiborisov
Copy link
Author

Works like a charm! Thank you @lehni! 🫶🏻

@ghost
Copy link

ghost commented Apr 20, 2023

In more recent updates, specifically version 1.77.3.23102, the patch you have provided appears to be ineffective, @lehni.

@lehni
Copy link

lehni commented Apr 20, 2023

@backermanbd I'm on 1.77.3. 23102 and it works perfectly for me. What are you seeing?

@ghost
Copy link

ghost commented Apr 20, 2023

Apologies for the inconvenience.

Initially, when I uninstalled the customize ui extension and installed your patched version, it didn't seem to function correctly. However, after performing a complete reinstallation and clearing all caches, the issue has been resolved and the patched version is now operational.

@lehni
Copy link

lehni commented Apr 20, 2023

Interesting, I had the same problem happening too. It may be that the previous version has left the app in a broken state when it started failing.

@daiyam
Copy link

daiyam commented Apr 20, 2023

Maybe in the UI db state.vscdb?

@lehni
Copy link

lehni commented Apr 25, 2023

I think it's related to leaving the patched and unpatched backup files in a a state of mess.

@zisra
Copy link

zisra commented Apr 28, 2023

@lehni Sorry for bothering, I installed both your custom extensions but nothing seems to have changed
Screenshot 2023-04-28 at 9 19 41 AM

@lehni
Copy link

lehni commented Jul 16, 2023

A little heads up to everybody interested that the new APC extension now offers a viable path forward, see:

drcika/apc-extension#52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants