-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proton: Add forcenvapi and enable for Tony Hawk's Pro Skater 1 + 2 #7344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15854db.
CW-Bug-Id: #22757
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
…ctions. CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729
CW-Bug-Id: #22729 CW-Bug-Id: #23000
ShellExecuteW ignores any extra information passed as part of lpFile resulting in arguments being ignored. Link: ValveSoftware#6555
To allow titles like Tony Hawk's Pro Skater 1+2 to support HDR on SteamOS by default. These games use statically linked AMD AGS.
misyltoad
changed the title
proton: Add forcenvapi
proton: Add forcenvapi and enable for Tony Hawk's Pro Skater 1 + 2
Dec 14, 2023
Depends on the relevant Proton Wine commit here: ValveSoftware/wine#209 |
ivyl
reviewed
Dec 14, 2023
self.env["WINE_HIDE_AMD_GPU"] = "1" | ||
if "DXVK_CONFIG" not in self.env: | ||
self.env["DXVK_CONFIG"] = ";" | ||
self.env["DXVK_CONFIG"] = "dxgi.hideAmdGpu = True" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we append ;
if DXVK_CONFIG
is in env
and if not set it to empty string and then append the hideAmdGpu
bit or am I misreading this?
Plagman
force-pushed
the
experimental_8.0
branch
from
December 20, 2023 20:14
851dee9
to
ba60f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow titles like Tony Hawk's Pro Skater 1+2 to support HDR on SteamOS by default.
These games use statically linked AMD AGS.