Treeification of Variation Diffs #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove it later.
…o DiffNode::assertConsistency
ibbem
requested changes
Feb 23, 2023
There was a problem hiding this comment.
Looks mostly good to me. The only bug I found is in DiffNode.toTextDiff but I request some API and implementation changes. I also added many nitpicks.
Thanks for the good commit hygiene (apart from 40cbe25 which could be split up next time to separate unrelated changes). Although some commit messages could provide a bit more context.
src/main/java/org/variantsync/diffdetective/variation/diff/DiffNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/diff/DiffNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/diff/DiffNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/diff/DiffNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/diff/DiffNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/diff/bad/DiffLineNumberRange.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/tree/VariationTree.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/tree/VariationTree.java
Outdated
Show resolved
Hide resolved
src/main/java/org/variantsync/diffdetective/variation/tree/VariationNode.java
Show resolved
Hide resolved
ibbem
approved these changes
Mar 1, 2023
Use `Time.forAll` in `BadVDiff.fromGood`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
BadVDiffs (Bad Variation Diffs) that are an alternative representation of variation diffs as trees instead of directed acyclic graphs. ABadVDiffis a variation diff in which any shared subtrees (i.e., sub-variation-diffs below a diamond structure) are duplicated to make the diff become a tree. This enables us to partly reuse existing functionality and research on variational tree languages, such as partial configurations.