Code

Treeification of Variation Diffs#67

Code

Merged

pmbittner merged 38 commits intodevelopVariantSync/DiffDetective:developfrom vpatchVariantSync/DiffDetective:vpatchCopy head branch name to clipboardMar 2, 2023

+687-103

Commits

Commits on Feb 17, 2023

• refactor: rename DiffNode::getDirectFeatureMapping to DiffNode::getFormula

  pmbittner

  committed
  3b9b9c7

  Copy full SHA for 3b9b9c7

• fix: warning and typo

  pmbittner

  committed
  840ad3c

  Copy full SHA for 840ad3c

• fix: fixed format string from digit to object for LineRange

  pmbittner

  committed
  468d033

  Copy full SHA for 468d033

• feat: first (dumb) version of good -> bad diff conversion

  pmbittner

  committed
  7fb2684

  Copy full SHA for 7fb2684

Commits on Feb 20, 2023

• fix: Assert::assertEquals does not crash on null parameters

  pmbittner

  committed
  513efe7

  Copy full SHA for 513efe7

• feat: VariationTree::forAll

  pmbittner

  committed
  0c5d14e

  Copy full SHA for 0c5d14e

• feat: DiffNode::toTextDiff with indent

  pmbittner

  committed
  8ff799b

  Copy full SHA for 8ff799b

• refactor: DiffType::matchBeforeAfter -> DiffType::forAllTimesOfExistence

  pmbittner

  committed
  bf6699b

  Copy full SHA for bf6699b

• refactor: DiffType::forAllTimesOfExistence with single time consumer

  pmbittner

  committed
  523e34f

  Copy full SHA for 523e34f

• fix: added deprecation warning for buggy toTextDiff method. We should remove it later.

  pmbittner

  committed
  69f3add

  Copy full SHA for 69f3add

Commits on Feb 21, 2023

• fix: deprecated old DiffGraph

  pmbittner

  committed
  d631e07

  Copy full SHA for d631e07

• fix: add check that parents can only be the same if it is unchanged to DiffNode::assertConsistency

  pmbittner

  committed
  d7f4bf5

  Copy full SHA for d7f4bf5

• feat: view for inspecting DiffTrees as graphs

  pmbittner

  committed
  d8fc9e3

  Copy full SHA for d8fc9e3

• feat: BadVDiff::toGood

  pmbittner

  committed
  40cbe25

  Copy full SHA for 40cbe25

• feat: unit tests for idempotency of toGood after fromGood

  pmbittner

  committed
  eb20a90

  Copy full SHA for eb20a90

• feat: make bad diffs a bit less bad

  pmbittner

  committed
  bd04b64

  Copy full SHA for bd04b64

• docs: GraphView

  pmbittner

  committed
  d492dff

  Copy full SHA for d492dff

• fix: add source to BadVDiff::toGood diffs

  pmbittner

  committed
  a090c4e

  Copy full SHA for a090c4e

• doc: for BadVDiff

  pmbittner

  committed
  6ce61f1

  Copy full SHA for 6ce61f1

Commits on Feb 28, 2023

• assert satisfaction of invariant in DiffNode::setFormula

  pmbittner

  committed
  9fb7e6c

  Copy full SHA for 9fb7e6c

• fix: delete buggy DiffNode::toTextDiff

  pmbittner

  committed
  9f1acb2

  Copy full SHA for 9f1acb2

• fix: grammar error in docs of DiffType::forAllTimesOfExistence

  pmbittner

  committed
  66e936a

  Copy full SHA for 66e936a

• refactor: GraphView -> FormalDiffGraph

  pmbittner

  committed
  d62b86e

  Copy full SHA for d62b86e

• refactor: use getters to access FormalDiffGraph::Edge fields

  pmbittner

  committed
  006122b

  Copy full SHA for 006122b

• fix: error sin docs for BadVDiff

  pmbittner

  committed
  aa56dd6

  Copy full SHA for aa56dd6

• fix: moved duplicate checks to assertion + docs

  pmbittner

  committed
  c684f4c

  Copy full SHA for c684f4c

• refactor: rename v to vtnode for more descriptive name

  pmbittner

  committed
  275f1b4

  Copy full SHA for 275f1b4

• docs: add reasoning on why we have to defer edge construction in BadVDiff::toGood

  pmbittner

  committed
  8476cc5

  Copy full SHA for 8476cc5

• docs: code blocks for ascii art

  pmbittner

  committed
  bf47112

  Copy full SHA for bf47112

• docs: for param BadVDiff::lines

  pmbittner

  committed
  dd77ec5

  Copy full SHA for dd77ec5

• refactor: moved DiffLineNumberRange to proper package

  pmbittner

  committed
  d867aa6

  Copy full SHA for d867aa6

• refactor: rename dir "bad" to "badvdiff"

  pmbittner

  committed
  d3d82c6

  Copy full SHA for d3d82c6

• refactor: remove duplicate code

  pmbittner

  committed
  7120586

  Copy full SHA for 7120586

• fix: some dead javadoc links

  pmbittner

  committed
  155075d

  Copy full SHA for 155075d

Commits on Mar 1, 2023

• Use Time.forAll in BadVDiff.fromGood

  ibbem

  committed
  8165c9b

  Copy full SHA for 8165c9b

Commits on Mar 2, 2023

• fix: remove redundant check for root in BadVDiff::toGood

  pmbittner

  committed
  16fe508

  Copy full SHA for 16fe508

• fix: by ibbem: Proper printing of multiline artifacts in BadVDiff::prettyPrint

  pmbittner

  committed
  9d34d5d

  Copy full SHA for 9d34d5d

• Merge pull request #69 from VariantSync/benjamin/vpatch/Time-forAll

  Show description for e5b4abd
  pmbittner

  authored
  e5b4abd

  Copy full SHA for e5b4abd