Workflow #6
Open
Workflow #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing tests
e2e testing complete
Fermain
suggested changes
May 11, 2024
| "env": { | ||
| "browser": true, | ||
| "es2021": true, | ||
| "jest/globals": true, |
There was a problem hiding this comment.
Suggested change
| "jest/globals": true, |
This is not required as a global configuration
| "extends": "eslint:recommended", | ||
| "overrides": [ | ||
| { | ||
| "files": ["/*.cy.js", "/*.test.ts"], |
There was a problem hiding this comment.
It looks like you have merged config for cypress and jest instead of giving these their own block.
| "extends": "eslint:recommended", | ||
| "overrides": [ | ||
| { | ||
| "files": ["/*.cy.js", "/*.test.ts"], |
There was a problem hiding this comment.
Suggested change
| "files": ["/*.cy.js", "/*.test.ts"], | |
| "files": ["/*.cy.js", "/*.test.js"], |
Is the .ts extension intentional?
| @@ -0,0 +1,38 @@ | |||
| describe("loginSuccessful", () => { | |||
| beforeEach(() => { | |||
| cy.visit("http://127.0.0.1:5500/"); | |||
There was a problem hiding this comment.
Suggested change
| cy.visit("http://127.0.0.1:5500/"); | |
| cy.visit("/"); |
| @@ -0,0 +1,14 @@ | |||
| describe("Logout function", () => { | |||
| it("Logs in the user, logs out, and makes sure the login button exists afterwards.", () => { | |||
| cy.visit("http://127.0.0.1:5500/"); | |||
There was a problem hiding this comment.
Suggested change
| cy.visit("http://127.0.0.1:5500/"); | |
| cy.visit("/"); |
| cy.get("#loginForm button").contains("Login").click(); | ||
| cy.wait(800); | ||
| cy.get('button[data-auth="logout"]').click(); | ||
| cy.get('.modal-footer button[data-auth="login"]').should("exist"); |
There was a problem hiding this comment.
You should check local storage here and assert a null token
| // | ||
| // | ||
| // -- This is a child command -- | ||
| // Cypress.Commands.add('drag', { prevSubject: 'element'}, (subject, options) => { ... }) |
| "bootstrap-dark-5": "^1.1.3" | ||
| } | ||
| "name": "css-frameworks-ca", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
Version should increase with your changes
| }, | ||
| "dependencies": { | ||
| "bootstrap-dark-5": "^1.1.3", | ||
| "dotenv": "^16.4.5" |
| "dotenv": "^16.4.5" | ||
| }, | ||
| "lint-staged": { | ||
| "*.js": "eslint --cache --fix" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added eslint, prettier and different commit hooks, and then Jest and and cypress to later on do some testing