forked from NoroffFEU/social-media-client
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow #6
Open
VeronicaOS
wants to merge
15
commits into
master
Choose a base branch
from
workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Workflow #6
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4cc843a
install eslint
VeronicaOS 56aa844
initialising eslint
VeronicaOS 97e6811
eslint+
VeronicaOS a9789dc
Merge pull request #1 from VeronicaOS/eslint
VeronicaOS 6f49fb0
fixing tests
VeronicaOS 306f242
Merge pull request #2 from VeronicaOS/eslint
VeronicaOS 459300e
finished
VeronicaOS 5cd293f
Merge pull request #3 from VeronicaOS/unit-testing
VeronicaOS a8b9473
e2e testing complete
VeronicaOS 43489bd
Merge pull request #4 from VeronicaOS/e2e
VeronicaOS 1de45ab
made a readme file
VeronicaOS ca16aae
added badges
VeronicaOS e02321c
done
VeronicaOS 4316716
last
VeronicaOS ab8aecd
Merge pull request #5 from VeronicaOS/readme
VeronicaOS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,29 @@ | ||||||
{ | ||||||
"env": { | ||||||
"browser": true, | ||||||
"es2021": true, | ||||||
"jest/globals": true, | ||||||
"node": true | ||||||
}, | ||||||
"extends": "eslint:recommended", | ||||||
"overrides": [ | ||||||
{ | ||||||
"files": ["/*.cy.js", "/*.test.ts"], | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like you have merged config for cypress and jest instead of giving these their own block. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Is the |
||||||
"env": { "cypress/globals": true }, | ||||||
"plugins": ["cypress", "jest"], | ||||||
"extends": [ | ||||||
"plugin:cypress/recommended", | ||||||
"plugin:jest/recommended" | ||||||
], | ||||||
"rules": { | ||||||
"cypress/no-unnecessary-waiting": "off", | ||||||
"no-unused-vars": "off", | ||||||
"jest/prefer-expect-assertions": "off" | ||||||
} | ||||||
} | ||||||
], | ||||||
"parserOptions": { | ||||||
"ecmaVersion": "latest", | ||||||
"sourceType": "module" | ||||||
} | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Workflow | ||
|
||
This project was about making the forked project better, by implemeting developement workflows and testing. | ||
|
||
## statusbadges | ||
|
||
 | ||
 | ||
|
||
## :zap: Getting stared | ||
|
||
### Installing: | ||
|
||
1. Clone the repo: | ||
|
||
```bash | ||
git clone git@github.com:VeronicaOS/social-media-client.git | ||
``` | ||
|
||
2. Install the necessary npm packages including those required for testing: | ||
|
||
```bash | ||
npm install | ||
``` | ||
|
||
### Testing: | ||
|
||
To run Cypress and Jest type in the command line: | ||
|
||
```bash | ||
npm run test | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"presets": [["@babel/preset-env", { "targets": { "node": "current" } }]] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
const { defineConfig } = require("cypress"); | ||
|
||
module.exports = defineConfig({ | ||
e2e: { | ||
setupNodeEvents(on, config) { | ||
// implement node event listeners here | ||
}, | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
/// <reference types="cypress" /> | ||
|
||
// Welcome to Cypress! | ||
// | ||
// This spec file contains a variety of sample tests | ||
// for a todo list app that are designed to demonstrate | ||
// the power of writing tests in Cypress. | ||
// | ||
// To learn more about how Cypress works and | ||
// what makes it such an awesome testing tool, | ||
// please read our getting started guide: | ||
// https://on.cypress.io/introduction-to-cypress | ||
|
||
describe('example to-do app', () => { | ||
beforeEach(() => { | ||
// Cypress starts out with a blank slate for each test | ||
// so we must tell it to visit our website with the `cy.visit()` command. | ||
// Since we want to visit the same URL at the start of all our tests, | ||
// we include it in our beforeEach function so that it runs before each test | ||
cy.visit('https://example.cypress.io/todo') | ||
}) | ||
|
||
it('displays two todo items by default', () => { | ||
// We use the `cy.get()` command to get all elements that match the selector. | ||
// Then, we use `should` to assert that there are two matched items, | ||
// which are the two default items. | ||
cy.get('.todo-list li').should('have.length', 2) | ||
|
||
// We can go even further and check that the default todos each contain | ||
// the correct text. We use the `first` and `last` functions | ||
// to get just the first and last matched elements individually, | ||
// and then perform an assertion with `should`. | ||
cy.get('.todo-list li').first().should('have.text', 'Pay electric bill') | ||
cy.get('.todo-list li').last().should('have.text', 'Walk the dog') | ||
}) | ||
|
||
it('can add new todo items', () => { | ||
// We'll store our item text in a variable so we can reuse it | ||
const newItem = 'Feed the cat' | ||
|
||
// Let's get the input element and use the `type` command to | ||
// input our new list item. After typing the content of our item, | ||
// we need to type the enter key as well in order to submit the input. | ||
// This input has a data-test attribute so we'll use that to select the | ||
// element in accordance with best practices: | ||
// https://on.cypress.io/selecting-elements | ||
cy.get('[data-test=new-todo]').type(`${newItem}{enter}`) | ||
|
||
// Now that we've typed our new item, let's check that it actually was added to the list. | ||
// Since it's the newest item, it should exist as the last element in the list. | ||
// In addition, with the two default items, we should have a total of 3 elements in the list. | ||
// Since assertions yield the element that was asserted on, | ||
// we can chain both of these assertions together into a single statement. | ||
cy.get('.todo-list li') | ||
.should('have.length', 3) | ||
.last() | ||
.should('have.text', newItem) | ||
}) | ||
|
||
it('can check off an item as completed', () => { | ||
// In addition to using the `get` command to get an element by selector, | ||
// we can also use the `contains` command to get an element by its contents. | ||
// However, this will yield the <label>, which is lowest-level element that contains the text. | ||
// In order to check the item, we'll find the <input> element for this <label> | ||
// by traversing up the dom to the parent element. From there, we can `find` | ||
// the child checkbox <input> element and use the `check` command to check it. | ||
cy.contains('Pay electric bill') | ||
.parent() | ||
.find('input[type=checkbox]') | ||
.check() | ||
|
||
// Now that we've checked the button, we can go ahead and make sure | ||
// that the list element is now marked as completed. | ||
// Again we'll use `contains` to find the <label> element and then use the `parents` command | ||
// to traverse multiple levels up the dom until we find the corresponding <li> element. | ||
// Once we get that element, we can assert that it has the completed class. | ||
cy.contains('Pay electric bill') | ||
.parents('li') | ||
.should('have.class', 'completed') | ||
}) | ||
|
||
context('with a checked task', () => { | ||
beforeEach(() => { | ||
// We'll take the command we used above to check off an element | ||
// Since we want to perform multiple tests that start with checking | ||
// one element, we put it in the beforeEach hook | ||
// so that it runs at the start of every test. | ||
cy.contains('Pay electric bill') | ||
.parent() | ||
.find('input[type=checkbox]') | ||
.check() | ||
}) | ||
|
||
it('can filter for uncompleted tasks', () => { | ||
// We'll click on the "active" button in order to | ||
// display only incomplete items | ||
cy.contains('Active').click() | ||
|
||
// After filtering, we can assert that there is only the one | ||
// incomplete item in the list. | ||
cy.get('.todo-list li') | ||
.should('have.length', 1) | ||
.first() | ||
.should('have.text', 'Walk the dog') | ||
|
||
// For good measure, let's also assert that the task we checked off | ||
// does not exist on the page. | ||
cy.contains('Pay electric bill').should('not.exist') | ||
}) | ||
|
||
it('can filter for completed tasks', () => { | ||
// We can perform similar steps as the test above to ensure | ||
// that only completed tasks are shown | ||
cy.contains('Completed').click() | ||
|
||
cy.get('.todo-list li') | ||
.should('have.length', 1) | ||
.first() | ||
.should('have.text', 'Pay electric bill') | ||
|
||
cy.contains('Walk the dog').should('not.exist') | ||
}) | ||
|
||
it('can delete all completed tasks', () => { | ||
// First, let's click the "Clear completed" button | ||
// `contains` is actually serving two purposes here. | ||
// First, it's ensuring that the button exists within the dom. | ||
// This button only appears when at least one task is checked | ||
// so this command is implicitly verifying that it does exist. | ||
// Second, it selects the button so we can click it. | ||
cy.contains('Clear completed').click() | ||
|
||
// Then we can make sure that there is only one element | ||
// in the list and our element does not exist | ||
cy.get('.todo-list li') | ||
.should('have.length', 1) | ||
.should('not.have.text', 'Pay electric bill') | ||
|
||
// Finally, make sure that the clear button no longer exists. | ||
cy.contains('Clear completed').should('not.exist') | ||
}) | ||
}) | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required as a global configuration