Fix Okta WebAuthn challenge

[anothertobi]

PR #1039 introduced a change to okta_webauthn.go that most probably
is a relic from the development phase of the Duo integration (ref:
82b3ba3).

Since the Duo integration implements its own ChallengeU2F, this should
be safe to revert.

[anothertobi]

Verified that this fixes Okta + WebAuthn using a YubiKey. Would be great if someone with Okta + Duo could double-check that this indeed doesn't break their setup (maybe @lizduty / @6f6d6172 ?).

[smlx]

I can confirm this fixes Okta U2F authentication for me.

[satyamab]

Thank you for fixing this! Also confirming that this fixes Okta U2F authentication for me. The impact is quite widespread for our eng team. Any idea when a release may be available for this fix? 🙏

[dasrecht]

Can also confirm this fix works as expected - Thanks @anothertobi!

[lizduty]

confirmed this doesn't break my workflow

…

On Thu, May 25, 2023 at 12:36 AM Bastian Widmer ***@***.***> wrote: Can also confirm this fix works as expected - Thanks @anothertobi <https://github.com/anothertobi>! — Reply to this email directly, view it on GitHub <#1059 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A664ZPN663VRKUOFCZH6POTXH4DYLANCNFSM6AAAAAAYLXS3IU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[smlx]

@anothertobi any chance you could take a look at the test failure? 🙂

[codecov-commenter]

Codecov Report

Merging #1059 (f4ecfc5) into master (83489ec) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   36.29%   36.29%           
=======================================
  Files          53       53           
  Lines        7941     7941           
=======================================
  Hits         2882     2882           
  Misses       4686     4686           
  Partials      373      373           

Flag	Coverage Δ
unittests	36.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/provider/okta/okta_webauthn.go	54.02% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[anothertobi]

@anothertobi any chance you could take a look at the test failure? 🙂

68806fe seems to have fixed the build, but the linter is timing out. Locally this runs through in < 1s 🤔

[anothertobi]

Rebased the branch and #1074 did fix the golangci-lint timeout we had earlier.

[roptoor]

Curious what more is needed to get this merged, as it seems to be affecting quite a few users?

[jmandel1027]

Heyyo, would it be possible to cut a new release with this patch? It looks like this is still affecting a large number of folks in our eng org too

[mapkon]

Yeah, we would need to test the current code for release readiness. If you volunteer to coordinate that, I would very much appreciate it

[szechyjs]

Any ETA on getting this released. We are dead in the water without this.

[anothertobi]

@szechyjs this PR is included in the v2.36.10 release.

[szechyjs]

@szechyjs this PR is included in the v2.36.10 release.

Good to hear. I didn't see it in the Changelog/Release Notes which is why I asked.