Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint #1074

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Update golangci-lint #1074

merged 4 commits into from
Jun 7, 2023

Conversation

anothertobi
Copy link
Contributor

  • Upgrade golangci-lint to v1.53.2
  • Increase timeout of golangci-lint
  • Remove deprecated golangci-lint linters

This addresses the linter timeouts as seen in #1059 and #1070.

Some CI jobs barely make it within the timeout and others do time out.
The removed linters are no longer maintained and have been replaced with
the linter `unused`.
@codecov-commenter
Copy link

Codecov Report

Merging #1074 (3dce284) into master (c00663f) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1074   +/-   ##
=======================================
  Coverage   36.29%   36.29%           
=======================================
  Files          53       53           
  Lines        7941     7941           
=======================================
  Hits         2882     2882           
  Misses       4686     4686           
  Partials      373      373           
Flag Coverage Δ
unittests 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mapkon mapkon merged commit dbf593a into Versent:master Jun 7, 2023
@anothertobi anothertobi deleted the update-linter branch June 7, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants