Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for okta + govcloud #476

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Fixes for okta + govcloud #476

merged 4 commits into from
Apr 17, 2020

Conversation

duckfez
Copy link
Contributor

@duckfez duckfez commented Apr 7, 2020

Fixes #475.

Added the known SAML signin pages for the AWS GovCloud (US) and AWS China into the okta provider, as well as into the SAML assertion parser.

Note this may not be good, idiomatic golang... Sorry, my first attempt at doing something with it.

@missingcharacter
Copy link
Contributor

@duckfez does this branch fails govcloud and AWS China for you too? #469

@duckfez
Copy link
Contributor Author

duckfez commented Apr 8, 2020

@missingcharacter I can't test AWS China, don't have an account there. When I started working on getting GovCloud (US) to work, I first fixed pkg/provider/okta/okta.go to add the GovCloud SAML URL there. Then, I ran into the problem in aws_account.go and saw the master branch already had been worked on for AWS China. So, I went back and added the AWS China URL into the okta provider as well.

@missingcharacter
Copy link
Contributor

@duckfez than maybe a better question is: do your changes to pkg/provider/okta/okta.go play well with #469 ?

@duckfez
Copy link
Contributor Author

duckfez commented Apr 8, 2020

@missingcharacter Based on my limited understanding of the code base - I think your changes in #469 in aws_account.go are likely superior to my own and should replace them. But, even with what you've done, my changes to the Okta provider are still necessary.

@missingcharacter
Copy link
Contributor

@duckfez I agree your okta changes are necessary, what I'm wondering is if both changes work together.

@duckfez
Copy link
Contributor Author

duckfez commented Apr 8, 2020

I'll merge #469 into what I have here and give it a try to see.

@duckfez
Copy link
Contributor Author

duckfez commented Apr 11, 2020

@missingcharacter I merged your branch with mine and fixed the small merge conflicts in aws_account.go. Very first test I get one of the errors that was reporting in #469:

Failed to assume role, please check whether you are permitted to assume the given role for the AWS service: error parsing aws role accounts: error retrieving AWS login form: Post "urn:amazon:webservices": unsupported protocol scheme "urn"

I'll work on trying to debug it and report back if I come up with anything.

@duckfez
Copy link
Contributor Author

duckfez commented Apr 12, 2020

Modified this to be dependent on (and avoid merge conflicts with) #481.

@wolfeidau wolfeidau merged commit 405598b into Versent:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OKTA + AWS GovCloud -- "unsupported protocol scheme"
3 participants