-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for okta + govcloud #476
Conversation
@missingcharacter I can't test AWS China, don't have an account there. When I started working on getting GovCloud (US) to work, I first fixed |
@missingcharacter Based on my limited understanding of the code base - I think your changes in #469 in |
@duckfez I agree your okta changes are necessary, what I'm wondering is if both changes work together. |
I'll merge #469 into what I have here and give it a try to see. |
@missingcharacter I merged your branch with mine and fixed the small merge conflicts in
I'll work on trying to debug it and report back if I come up with anything. |
Modified this to be dependent on (and avoid merge conflicts with) #481. |
Fixes #475.
Added the known SAML signin pages for the AWS GovCloud (US) and AWS China into the okta provider, as well as into the SAML assertion parser.
Note this may not be good, idiomatic golang... Sorry, my first attempt at doing something with it.