Get the AWS destination from the Destination, not Audience #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @duckfez |
|
@missingcharacter I think this is the last one. This fixes the blank |
|
@duckfez I can confirm this works for me too, thanks :) |
|
I closed #469 in favor of this PR |
duckfez
added a commit
to duckfez/saml2aws
that referenced
this pull request
Apr 12, 2020
|
I just tested these new changes and still works, once again, thanks @duckfez |
|
Thanks @wolfeidau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional work on top of #469 to support how Okta's SAML response is formatted. Okta returns the
Audienceasurn:amazon:webserviceswhich is not that useful. So this updates to grab theDestinationattribute of the root element of the SAML response.