Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ini parser considers hash as an inline comment and removes it. Instead
we configure the parser to only consider hash an inline comment when it
is preceded by a space.
An example where this is useful: when you add a Custom SAML Application to AWS SSO you can't use the normal
aws sso login
process to get your credentials, you need to use something like saml2aws, currently in browser mode. Problem with browser mode is that AWS SSO page will open links in a new tab so playwright won't find the correct redirect since it happens in another tab.So I figured out two solutions:
Since the link is actually just the SSO page with appended hash (which triggers a POST), I need to add the hash to the URL which currently doesn't work because the INI parsers thinks it's a comment.