Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hash in URL #727

Merged
merged 3 commits into from
Oct 20, 2021
+3 −4
Merged

Allow hash in URL #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8b15be
Allow hash in URL
v3rm0n Sep 16, 2021
8a78b2b
Merge branch 'master' into hash-url
v3rm0n Oct 11, 2021
bb718bf
Merge branch 'master' into hash-url
Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cfg/cfg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func (cm *ConfigManager) SaveIDPAccount(idpAccountName string, account *IDPAccou
// LoadIDPAccount load the idp account and default to an empty one if it doesn't exist
func (cm *ConfigManager) LoadIDPAccount(idpAccountName string) (*IDPAccount, error) {

cfg, err := ini.LoadSources(ini.LoadOptions{Loose: true}, cm.configPath)
cfg, err := ini.LoadSources(ini.LoadOptions{Loose: true, SpaceBeforeInlineComment: true}, cm.configPath)
if err != nil {
return nil, errors.Wrap(err, "Unable to load configuration file")
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cfg/cfg_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func TestNewConfigManagerLoad(t *testing.T) {
require.Nil(t, err)
require.Equal(t, &IDPAccount{
Name: "test123",
URL: "https://id.whatever.com",
URL: "https://id.whatever.com/#/hash",
Username: "abc@whatever.com",
Provider: "keycloak",
MFA: "sms",
Expand Down
3 changes: 1 addition & 2 deletions pkg/cfg/example/saml2aws.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ mfa = totp
username = abc@whatever.com
provider = keycloak
mfa = sms
url = https://id.whatever.com
url = https://id.whatever.com/#/hash
skip_verify = false
timeout = 0