Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the release build to use macos-latest #961

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Revert the release build to use macos-latest #961

merged 2 commits into from
Feb 28, 2023

Conversation

mapkon
Copy link
Contributor

@mapkon mapkon commented Feb 28, 2023

@mapkon @wolfeidau
Revert the release build to use macos-latest
ca58526 
 - This functionality was broken in #951
 - Since we are using OSX toolchain, we need macos-X to build

Co-authored-by: Mark Wolfe <mark@wolfe.id.au>
@mapkon mapkon self-assigned this Feb 28, 2023
@wolfeidau wolfeidau self-requested a review February 28, 2023 23:02
wolfeidau
wolfeidau approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 🚀

@mapkon mapkon merged commit 509e234 into master Feb 28, 2023
@mapkon mapkon deleted the revert-to-macos-builds branch February 28, 2023 23:10
@smlx smlx mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfeidau wolfeidau wolfeidau approved these changes

Assignees

@mapkon mapkon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mapkon @wolfeidau