Use native OS build workers #962
Conversation
This split is required because the hidraw tag and CGO is required for linux builds. This is a requirement of the go-u2fhost dependency. See https://github.com/marshallbrekka/go-u2fhost#linux for details. Similarly, macOS binaries must be built on macOS. This change also updates the github workflows to support the new split goreleaser config.
|
cc @mapkon |
There was a problem hiding this comment.
Thank you for the PR - but I don't think it is ready yet.
It looks like the split is not working properly - please see the output from a scratch repo I created here: https://github.com/mapkon/go-releaser-tinker/actions/runs/4319873504/jobs/7539569017
It appears that the second release (macos-latest) attempts to (re)upload the go-releaser-tinker_0.1.0_checksums.txt file, leading to this error:
⨯ release failed after 12s
error=scm releases: failed to publish artifacts: failed to upload go-releaser-tinker_0.1.0_checksums.txt after 1 tries:
POST https://uploads.github.com/repos/mapkon/go-releaser-tinker/releases/94362976/assets?name=go-releaser-tinker_0.1.0_checksums.txt: 422 Validation Failed
[{Resource:ReleaseAsset Field:name Code:already_exists Message:}]
Error: The process '/Users/runner/hostedtoolcache/goreleaser-action/1.15.2/x64/goreleaser' failed with exit code 1
Can you take a look?
smlx
force-pushed
the
split-build-workers
branch
from
c4bd4c1
to
927e7a2
Compare
.goreleaser.ubuntu-latest.yml
Outdated
| @@ -34,3 +34,5 @@ archives: | |||
| files: | |||
| - LICENSE.md | |||
| - README.md | |||
| checksum: | |||
| name_template: "{{ .ProjectName }}_{{ .Version }}_linux_windows_checksums.txt" | |||
There was a problem hiding this comment.
Would it make sense to just use the "{{ .ProjectName }}_{{ .Version }}_checksums.txt" to cater for Windows and Linux?
CC: @wolfeidau
There was a problem hiding this comment.
ok, I've made the change
smlx
force-pushed
the
split-build-workers
branch
from
927e7a2
to
86b22ab
Compare
|
Sorry about the bug - I've tested a few times and should be fixed now. |
No worries! Will take a look at the earliest opportune time. |
This PR updates the Github build and release workflows to be OS-native: macOS binaries built on macOS, and Linux binaries built on Linux.
It also updates the
buildtarget in theMakefileto handle the splitgoreleaserconfiguration.It should fix the issue described in #961