Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCI-98: Fix bin and obj directories search in Clean target #10

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

krankenbro
Copy link
Collaborator

@mvktsk
Copy link
Contributor

mvktsk commented Aug 5, 2021

Review task https://virtocommerce.atlassian.net/browse/VP-7626 has been created

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@krankenbro krankenbro merged commit 1f71c51 into dev Aug 13, 2021
@krankenbro krankenbro deleted the fix/vci-98 branch August 13, 2021 06:30
dimitri-ak pushed a commit that referenced this pull request Aug 20, 2021
* PT-2240: Add force parameter

* PT-1856: Update to .Net5

* PT-2240: Use StingBuilder

* PT-1856: Fix nuke update notify

* VP-7499: Remove redundant condition (#3)

* VCI-64: Remove tmp directory on exit

* PT-1795: Add case insensitivity for module installation (#4)

* PT-2099: Reset release branch if already exists (#5)

* PT-1799: Update docs (#6)

* VCI-74: Add workflow (#9)

* VCI-74: Add workflow

* VCI-74: Remove .nuke dir

* VCI-74: Change vc-build version in workflow

* VCI-74: Increase vc-build version

* VCI-74: Increase vc-build version

* VCI-74: Add PackageVersion

* VCI-74: Increase vc-build version

* VCI-74: Pass project type for get-image-version

* VCI-74: Remove redundant step from workflow

* VCI-74: Fix copyright year

* VCI-80: Fix missing dlls in app_data (#7)

* VCI-80: Fix modules installation

* VCI-64: Fix FileNotFoundException in ClearTemp

* VCI-64: Add removing of zip files after modules installation

* VCI-80: Fix nuget properties when module

* VCI-74: Check if modulemanifestpath is null

* VCI-80: Add _build project search

* VCI-95 Refactoring (#8)

* Add .editorconfig

* Format on save

* Fix formatting and style using ReSharper Code Cleanup

* Remove redundant base class

* Convert all build parameters to public static properties

* Fix compilation warnings

* Treat warnings as errors

* Fix spelling, add custom words to the dictionary

* Fix naming

* Make all targets public

* Fix settings when building NuGet package for a module

* Remove unused variables

* Make properties protected

* Refactoring

* Fix NullreferenceException and ArgumentNullException

* Move fields

* Move properties

* Remove commented out code

* Fix spelling/grammar

Co-authored-by: Alexandr Morogov <42555001+krankenbro@users.noreply.github.com>

* VCI-108: Update changelog

* VCI-108: Change GetCatalog parameter type

* VCI-108: Remove redundant nuget property

* VCI-108: Disable TreatWarningsAsErrors

* VCI-100: vc-build - release 2.0

* VCI-98: Fix bin and obj directories search in Clean target (#10)

* VCI-98: Fix bin and obj directories search in Clean target

* VCI-98: Fix codesmells

* VCI-100: vc-build - release 2.0

* VCI-116: Fix modules installation (#11)

* VCI-100: vc-build - release 2.0

* VCI-107: Fix version downgrade issue (#12)

* VCI-91: Add manifest creation from existing environment (#13)

* VCI-91: Add manifest creation from existing environment

* VCI-91: Fix codesmell

* VCI-128: Fix codesmells (#14)

* VCI-102: Add help command (#15)

* VCI-102: Add help command

* VCI-102: Fix codesmells

* VCI-102: Make HelpProvider static

* VCI-129: Make help search case insensitive

* VCI-128: Fix codesmells (#16)

* VCI-128: Fix long live branches list

* VCI-128: Remove redundant properties

Co-authored-by: Artyom Dudarev <ad@virtoway.com>
Co-authored-by: Dimitri Kargapolov <dk@virtoway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants