VCI-128: Fix codesmells #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
Review task https://virtocommerce.atlassian.net/browse/VP-7646 has been created |
dimitri-ak
pushed a commit
that referenced
this pull request
Aug 20, 2021
* PT-2240: Add force parameter * PT-1856: Update to .Net5 * PT-2240: Use StingBuilder * PT-1856: Fix nuke update notify * VP-7499: Remove redundant condition (#3) * VCI-64: Remove tmp directory on exit * PT-1795: Add case insensitivity for module installation (#4) * PT-2099: Reset release branch if already exists (#5) * PT-1799: Update docs (#6) * VCI-74: Add workflow (#9) * VCI-74: Add workflow * VCI-74: Remove .nuke dir * VCI-74: Change vc-build version in workflow * VCI-74: Increase vc-build version * VCI-74: Increase vc-build version * VCI-74: Add PackageVersion * VCI-74: Increase vc-build version * VCI-74: Pass project type for get-image-version * VCI-74: Remove redundant step from workflow * VCI-74: Fix copyright year * VCI-80: Fix missing dlls in app_data (#7) * VCI-80: Fix modules installation * VCI-64: Fix FileNotFoundException in ClearTemp * VCI-64: Add removing of zip files after modules installation * VCI-80: Fix nuget properties when module * VCI-74: Check if modulemanifestpath is null * VCI-80: Add _build project search * VCI-95 Refactoring (#8) * Add .editorconfig * Format on save * Fix formatting and style using ReSharper Code Cleanup * Remove redundant base class * Convert all build parameters to public static properties * Fix compilation warnings * Treat warnings as errors * Fix spelling, add custom words to the dictionary * Fix naming * Make all targets public * Fix settings when building NuGet package for a module * Remove unused variables * Make properties protected * Refactoring * Fix NullreferenceException and ArgumentNullException * Move fields * Move properties * Remove commented out code * Fix spelling/grammar Co-authored-by: Alexandr Morogov <42555001+krankenbro@users.noreply.github.com> * VCI-108: Update changelog * VCI-108: Change GetCatalog parameter type * VCI-108: Remove redundant nuget property * VCI-108: Disable TreatWarningsAsErrors * VCI-100: vc-build - release 2.0 * VCI-98: Fix bin and obj directories search in Clean target (#10) * VCI-98: Fix bin and obj directories search in Clean target * VCI-98: Fix codesmells * VCI-100: vc-build - release 2.0 * VCI-116: Fix modules installation (#11) * VCI-100: vc-build - release 2.0 * VCI-107: Fix version downgrade issue (#12) * VCI-91: Add manifest creation from existing environment (#13) * VCI-91: Add manifest creation from existing environment * VCI-91: Fix codesmell * VCI-128: Fix codesmells (#14) * VCI-102: Add help command (#15) * VCI-102: Add help command * VCI-102: Fix codesmells * VCI-102: Make HelpProvider static * VCI-129: Make help search case insensitive * VCI-128: Fix codesmells (#16) * VCI-128: Fix long live branches list * VCI-128: Remove redundant properties Co-authored-by: Artyom Dudarev <ad@virtoway.com> Co-authored-by: Dimitri Kargapolov <dk@virtoway.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.