Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added [POST] action #75

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Added [POST] action #75

merged 1 commit into from
Feb 6, 2020

Conversation

akak1977
Copy link
Contributor

@akak1977 akak1977 commented Feb 6, 2020

Added another method with endpoint "api/catalog/products/prices/search", but [Post] and [FromBody] parameter

@akak1977 akak1977 requested a review from tatarincev February 6, 2020 08:26
@vc-ci
Copy link
Contributor

vc-ci commented Feb 6, 2020

SonarQube analysis reported 9 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR PricingModuleController.cs#L407: Extract the assignment of 'batch' from this expression. rule
  2. MINOR PricingModuleController.cs#L26: Remove the field '_catalogService' and declare it as a local variable in the relevant methods. rule
  3. MINOR PricingModuleController.cs#L407: Use '.Any()' to test whether this 'IEnumerable' is empty or not. rule
  4. INFO PricingModuleController.cs#L244: Complete the task associated to this 'TODO' comment. rule
  5. INFO PricingModuleController.cs#L244: Complete the task associated to this 'TODO' comment. rule
  6. INFO PricingModuleController.cs#L373: Complete the task associated to this 'TODO' comment. rule
  7. INFO PricingModuleController.cs#L373: Complete the task associated to this 'TODO' comment. rule
  8. INFO PricingModuleController.cs#L389: Complete the task associated to this 'TODO' comment. rule
  9. INFO PricingModuleController.cs#L389: Complete the task associated to this 'TODO' comment. rule

@akak1977 akak1977 merged commit d16be0a into dev Feb 6, 2020
@akak1977 akak1977 deleted the bug/VP-1393-SearchProductPrices-as-get branch February 6, 2020 15:00
akak1977 added a commit that referenced this pull request Feb 6, 2020
@akak1977
Added another method with endpoint "api/catalog/products/prices/searc…
d7a1d20 
…h", but [Post] and [FromBody] parameter (#75) (#76)

* Added another method with endpoint "api/catalog/products/prices/search", but [Post] and [FromBody] parameter (#75)

* 2.18.12
@yecli yecli mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatarincev tatarincev tatarincev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akak1977 @vc-ci @tatarincev