Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP-1850: Allow to search prices using POST request #83

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

yecli
Copy link
Contributor

@yecli yecli commented Apr 6, 2020

  • Migrated changes from v2: Added [POST] action #75. Added POST endpoint to bypass search criteria without GET reuqest restrictions;

@yecli yecli requested review from akak1977 and tatarincev April 6, 2020 10:46
@yecli yecli requested a review from tatarincev April 6, 2020 11:18
@vc-ci
Copy link
Contributor

vc-ci commented Apr 6, 2020

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. INFO PricingModuleController.cs#L248: Complete the task associated to this 'TODO' comment. rule
  2. INFO PricingModuleController.cs#L248: Complete the task associated to this 'TODO' comment. rule
  3. INFO PricingModuleController.cs#L377: Complete the task associated to this 'TODO' comment. rule
  4. INFO PricingModuleController.cs#L377: Complete the task associated to this 'TODO' comment. rule
  5. INFO PricingModuleController.cs#L393: Complete the task associated to this 'TODO' comment. rule
  6. INFO PricingModuleController.cs#L393: Complete the task associated to this 'TODO' comment. rule

@akak1977 akak1977 merged commit 88b3d32 into release/3.0.0 Apr 6, 2020
@akak1977 akak1977 deleted the feature/3.0.0/VP-1850-actualize-from-v2 branch April 6, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants