-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hardening] Have one atomic function call on compass for all handovers #1960
Comments
@webelf101 Here's the suggested implementation:
That new function should:
That way, when we upgrade compass, we can call the old compass once. The submit logic call batch would contain the calls to This would be a great improvement on the current situation, where we have to make |
VolumeFi/paloma-compass-evm@ee37fff |
# Related Github tickets - VolumeFi#1960 - VolumeFi#1951 - VolumeFi#1956 - VolumeFi#2043 # Background This change makes use of the atomic handover endpoint on compass, re-enables the token relink and ensures ownership of fee manager is transferred as well. # Testing completed - [x] test coverage exists or has been added/updated - [x] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
# Related Github tickets - VolumeFi#1960 - VolumeFi#1951 - VolumeFi#1956 - VolumeFi#2043 # Background This change makes use of the atomic handover endpoint on compass, re-enables the token relink and ensures ownership of fee manager is transferred as well. # Testing completed - [x] test coverage exists or has been added/updated - [x] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
Instead of making
n
calls to change ownership of ERC20 tokens and fee manager and potentially ending in a situation where some calls went through and other don't, it would be faster and more efficient to have only one function on compass to call, that forwards handover calls to all tokens and the fee manage.Since those will all be in the same TX, it will either go through or fail.
The text was updated successfully, but these errors were encountered: