Fix issue #51: add environment variable placeholders for FROM_NUMBER … #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UMBER and VONAGE_API_SIGNATURE_SECRET so things work when running sms/send-signed-sms.php
…ent to caution use of criteria starting with '0' to avoid conversion-to-octal issues. Added some more comments while I was at it to help users understand the use of the filter object
dragonmantank
requested changes
Oct 5, 2020
| @@ -9,8 +9,17 @@ | |||
| $client = new \Vonage\Client($basic); | |||
|
|
|||
| /** @var IterableAPICollection $response */ | |||
| /** Note: be careful when specifying "NUMBER_SEARCH_CRITERIA" environment variable: | |||
There was a problem hiding this comment.
Can we revert the changes made in this file and handle it all in #60 ?
There was a problem hiding this comment.
I'm afraid I have made a monumental mess of these pull requests.
Do you want to just close these two and I will create a new pull request with a single, merged commit that has fixes for both Issue #51 and Issue #52? I will merge them into my forked master branch as a squash commit and then create a pull request for you. How does that sound? Thank you for being patient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and VONAGE_API_SIGNATURE_SECRET so things work when running sms/send-signed-sms.php
Fixes Issue #51