Fix #52 - cast 'NUMBER_SEARCH_CRITERIA' as (string). #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UMBER and VONAGE_API_SIGNATURE_SECRET so things work when running sms/send-signed-sms.php
…ent to caution use of criteria starting with '0' to avoid conversion-to-octal issues. Added some more comments while I was at it to help users understand the use of the filter object
…ent to caution use of criteria starting with '0' to avoid conversion-to-octal issues. Added some more comments while I was at it to help users understand the use of the filter object
dragonmantank
requested changes
Oct 5, 2020
numbers/search-available.php
Outdated
| /** Note: be careful when specifying "NUMBER_SEARCH_CRITERIA" environment variable: | ||
| * surround it with quotes if it has a leading zero, otherwise the (string) conversion | ||
| * will assume it is an Octal number and convert it. e.g., (string)0123 results in "83". | ||
| * NUMBER_SEARCH_PATTERN will be one of 0 (search for numbers that start with pattern); |
There was a problem hiding this comment.
I'm good with the warning above, but an we remove the options listed here? The allowed options are all listed on https://developer.nexmo.com/numbers/code-snippets/search-available/php, and it's expected that these snippets are being used with the documentation versus stand-alone.
The information in the code snippet duplicates the online documentation, so there is no need to include it in the PHP code.
|
removed the superfluous comment options. |
The information in the code snippet duplicates the online documentation, so there is no need to include it in the PHP code.
…com/gthoffer/vonage-php-code-snippets into 52_numbers_search_pattern_exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comment to caution use of criteria starting with '0' to avoid conversion-to-octal issues. Added some more comments while I was at it to help users understand the use of the filter object