Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation: Move the DNS/IPs out of hardcoded variables and into their own separate text files #301

Open
yllekz opened this issue May 18, 2022 · 1 comment

Comments

@yllekz
Copy link

yllekz commented May 18, 2022

I'm not sure if this repo is maintained anymore, but just from a QoL/best practice perspective, I found it interesting that the server names and IPs were hardcoded into the PowerShell scripts. This makes it difficult to read the raw data if one wanted to say, import the list into Pi-Hole and block the servers from the network. From a maintenance perspective, it also separates the script's functional portions from the ephemeral data (i.e., the ever-changing servers/IPs).

Could it be possible to move the server names/IPs specified in the debloat ps1 files to their own separate and sanitized text files?

@W4RH4WK
Copy link
Owner

W4RH4WK commented May 19, 2022

It's only barely maintained at this point since I lack the time to adapt existing code and test new additions.

It's certainly possible to read the ip/domain lists from an external file, next to the scripts.

If somebody gives me a PR that adjusts the code accordingly, I'd be happy to merge it.

chamele0n added a commit to chamele0n/Debloat-Windows-10 that referenced this issue Feb 13, 2023
This PR implements the recommended changes from issue W4RH4WK#301
chamele0n added a commit to chamele0n/Debloat-Windows-10 that referenced this issue Feb 13, 2023
This PR implements the recommended changes from issue W4RH4WK#301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants