Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changes for issue #301 #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chamele0n
Copy link
Contributor

This PR implements the recommended changes from issue #301

This PR implements the recommended changes from issue W4RH4WK#301
This PR implements the recommended changes from issue W4RH4WK#301
@MagicLike
Copy link

MagicLike commented Aug 3, 2023

Hey there @chamele0n as this repo is currently not really maintained, would you mind opening this PR on my fork? I am trying to somehow semi-maintain it and this small fix would be great!

@chamele0n
Copy link
Contributor Author

Hey there @chamele0n as this repo is currently not really maintained, would you mind opening this PR on my fork? I am trying to somehow semi-maintain it and this small fix would be great!

I think it failed the request (if I even did it right), it said I must be a collaborator.

@MagicLike
Copy link

Hey there @chamele0n as this repo is currently not really maintained, would you mind opening this PR on my fork? I am trying to somehow semi-maintain it and this small fix would be great!

I think it failed the request (if I even did it right), it said I must be a collaborator.

ok weird - i can invite you to be a collaborator and after that remove you again, as you can't fork a fork when you already forked the original (did that make sense?)

But to be clear: you can't edit a file and open a pr with some kind of a patch-something branch?

@Kreijstal
Copy link

you can change the name of your fork then you can fork it as many times as you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants