Add email template for file expiry #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-z
reviewed
Oct 22, 2024
ben-z
reviewed
Oct 23, 2024
| @@ -11,7 +11,7 @@ import { getAsset, registerAsset, WATcloudURI } from "../../utils/watcloud-uri"; | |||
| registerAsset('watcloud-logo', new WATcloudURI("watcloud://v1/sha256:393767e36d5387815c15d11c506c3c820de5db41723ffc062751673621dedb15?name=1024x512%20black%401x.png")) | |||
|
|
|||
| // Wrapper for WATcloud-themed emails | |||
| export function WATcloudEmail({ | |||
| export function Email({ | |||
There was a problem hiding this comment.
Suggested change
| export function Email({ | |
| export function WATcloudEmail({ |
Oh we should keep this as-is. I was talking about the per-email function names.
|
|
||
| type EmailProps = z.infer<typeof EmailProps>; | ||
|
|
||
| export const FileExpiryEmail = (props: EmailProps) => { |
There was a problem hiding this comment.
This can be called email, because we don't use it externally anyway.
Suggested change
| export const FileExpiryEmail = (props: EmailProps) => { | |
| const Email = (props: EmailProps) => { |
| const { name, paths, daysForExpiry, deletionDate} = EmailProps.parse(props); | ||
|
|
||
| const previewText = `You have expired files in the WATO drives`; | ||
| const mapPathToMachine = (): Record<string, string[]> => { |
There was a problem hiding this comment.
I feel like we can just keep this simple and just list the strings, don't need to group by machine. But that's up to you.
|
DIDN"T MEAN TO MERGE! |
cehune
added a commit
that referenced
this pull request
Oct 28, 2024
Add custom email type for notifying users when their files expire  Continuation of #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a unique email template for sending file expiry related emails.
Lists the expired emails from each machine
Tested using the cli to generate emails and it gives output as expected.