Support attributionsrc on <area> #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnivdel
approved these changes
Nov 15, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 6, 2024
This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 6, 2024
This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1392912}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 6, 2024
This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1392912}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 11, 2024
…through IDL, a=testonly Automatic update from web-platform-tests Expose attributionsrc support on <area> through IDL This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1392912} -- wpt-commits: 9535d4d010f2b40dc7f406d2c0ca53b8bda84e2c wpt-pr: 49568
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Dec 12, 2024
…through IDL, a=testonly Automatic update from web-platform-tests Expose attributionsrc support on <area> through IDL This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1392912} -- wpt-commits: 9535d4d010f2b40dc7f406d2c0ca53b8bda84e2c wpt-pr: 49568
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 13, 2024
…through IDL, a=testonly Automatic update from web-platform-tests Expose attributionsrc support on <area> through IDL This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268 Reviewed-by: Nate Chapin <japhetchromium.org> Reviewed-by: Domenic Denicola <domenicchromium.org> Commit-Queue: Andrew Paseltiner <apaseltinerchromium.org> Reviewed-by: John Delaney <johnidelchromium.org> Cr-Commit-Position: refs/heads/main{#1392912} -- wpt-commits: 9535d4d010f2b40dc7f406d2c0ca53b8bda84e2c wpt-pr: 49568 UltraBlame original commit: a14e525cf3faf4ce08f70c3a8210d6ac8ff17a67
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 13, 2024
…through IDL, a=testonly Automatic update from web-platform-tests Expose attributionsrc support on <area> through IDL This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268 Reviewed-by: Nate Chapin <japhetchromium.org> Reviewed-by: Domenic Denicola <domenicchromium.org> Commit-Queue: Andrew Paseltiner <apaseltinerchromium.org> Reviewed-by: John Delaney <johnidelchromium.org> Cr-Commit-Position: refs/heads/main{#1392912} -- wpt-commits: 9535d4d010f2b40dc7f406d2c0ca53b8bda84e2c wpt-pr: 49568 UltraBlame original commit: a14e525cf3faf4ce08f70c3a8210d6ac8ff17a67
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 13, 2024
…through IDL, a=testonly Automatic update from web-platform-tests Expose attributionsrc support on <area> through IDL This was already unintentionally supported due to the handling of the attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to support anyway, as <area> is a first-class navigation surface, just like the already supported <a> and window.open. WICG/attribution-reporting-api#1465 I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com Bug: 369219144, 379275911 Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268 Reviewed-by: Nate Chapin <japhetchromium.org> Reviewed-by: Domenic Denicola <domenicchromium.org> Commit-Queue: Andrew Paseltiner <apaseltinerchromium.org> Reviewed-by: John Delaney <johnidelchromium.org> Cr-Commit-Position: refs/heads/main{#1392912} -- wpt-commits: 9535d4d010f2b40dc7f406d2c0ca53b8bda84e2c wpt-pr: 49568 UltraBlame original commit: a14e525cf3faf4ce08f70c3a8210d6ac8ff17a67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns
<area>with<a>, as both are used for navigations.Preview | Diff