Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose attributionsrc support on <area> through IDL #49568

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 6, 2024

This was already unintentionally supported due to the handling of the
attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to
support anyway, as <area> is a first-class navigation surface, just like
the already supported <a> and window.open.

WICG/attribution-reporting-api#1465

I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com

Bug: 369219144, 379275911
Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1392912}

This was already unintentionally supported due to the handling of the
attributionsrc attribute on HTMLAnchorBaseElement, and is reasonable to
support anyway, as <area> is a first-class navigation surface, just like
the already supported <a> and window.open.

WICG/attribution-reporting-api#1465

I2S: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/673f72a6.2b0a0220.3bb1d2.02f2.GAE%40google.com

Bug: 369219144, 379275911
Change-Id: I7230229de087c752af7a5be2f7663fff999d66e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022268
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1392912}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9535d4d into master Dec 6, 2024
17 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-6022268 branch December 6, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants