Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joinAdInterestGroup, how to specify products? #150

Closed
jonasz opened this issue Mar 16, 2021 · 1 comment
Closed

joinAdInterestGroup, how to specify products? #150

jonasz opened this issue Mar 16, 2021 · 1 comment

Comments

@jonasz
Copy link
Contributor

jonasz commented Mar 16, 2021

The explainer gives the following spec for joinAdInterestGroup:

const myGroup = {
  (...)
  'ads': [shoes_ad1, shoes_ad2, shoes_ad3],
};
navigator.joinAdInterestGroup(myGroup, 30 * kSecsPerDay);

(...)

The ads list contains the various ads that the interest group might show. Each entry is an object that includes both a rendering URL and arbitrary metadata that can be used at bidding time.

At first glance, it may feel natural to specify products in an additional field within each ad. It seems however that the browser needs clarity about what products are included in the interest group. (For the same reason it needs clarity about ads: microtargeting prevention, ad_render_fingerprint, potentially downloading web bundles in future, ...)

I was wondering how should products be specified, is it the intention to list products alongside ads? Or should we perhaps add a separate field?

const myGroup = {
  (...)
  'ads': [shoes_ad1, shoes_ad2, shoes_ad3],
  'products': [shoe_product1, shoe_product2,...],
};

Best regards,
Jonasz

jonasz added a commit to jonasz/turtledove that referenced this issue May 21, 2021
jonasz added a commit to jonasz/turtledove that referenced this issue Jun 8, 2021
michaelkleber pushed a commit that referenced this issue Sep 9, 2021
* Clarifying product-level specification.

Adresses issues: #150, #151, #160.

* Better description of trustedBiddingSignalsKeys.

* Drop the idea of shallow merge in daily updates

At the same time, let's keep `ads` and `adComponents` as separate
fields, so as to maintain some flexibility in daily updates of ads.

* Drop the clarification on prevWins
@jonasz
Copy link
Contributor Author

jonasz commented Sep 13, 2021

Solved with pullreq #185 which introduced a new interest group field, adComponents.

@jonasz jonasz closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant