Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prev_wins and PLTD #151

Open
jonasz opened this issue Mar 16, 2021 · 0 comments
Open

prev_wins and PLTD #151

jonasz opened this issue Mar 16, 2021 · 0 comments

Comments

@jonasz
Copy link
Contributor

jonasz commented Mar 16, 2021

The specification of generate_bid introduces a field named prev_wins:

 'prev_wins': [[time1,ad1],[time2,ad2],...],

I was wondering, how would that signal be constructed in case of multi-product ads? (Section 3.4, "Ads Composed of Multiple Pieces")

It would be great to obtain information about specific products that were displayed to the user, for example:

 'prev_wins': [[time1, ad1, [product1_1, product1_2]],
               [time2, ad2, []],
               [time3, ad3, [product3_1, product 3_2, product 3_3]],
jonasz added a commit to jonasz/turtledove that referenced this issue May 21, 2021
@jonasz
Clarifying product-level specification.
2e6db4c 
Adresses issues: WICG#150, WICG#151, WICG#160.
@jonasz jonasz mentioned this issue May 21, 2021
Merged
jonasz added a commit to jonasz/turtledove that referenced this issue Jun 8, 2021
@jonasz
Clarifying product-level specification.
789c636 
Adresses issues: WICG#150, WICG#151, WICG#160.
michaelkleber pushed a commit that referenced this issue Sep 9, 2021
@jonasz
Clarifying product-level specification. (#185)
7e917a1 
* Clarifying product-level specification.

Adresses issues: #150, #151, #160.

* Better description of trustedBiddingSignalsKeys.

* Drop the idea of shallow merge in daily updates

At the same time, let's keep `ads` and `adComponents` as separate
fields, so as to maintain some flexibility in daily updates of ads.

* Drop the clarification on prevWins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasz