Forbid auctions from having both buyers and component auctions #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Kleber <kleber@google.com>
|
I support that plan ("announce the change, give folks a couple weeks to raise concerns, and then let the change percolate through to stable"). Note that https://github.com/WICG/turtledove/blob/main/fledge-tester-list.md lists only two parties who have spoken up about testing the SSP role, Google and OpenX, and we have buy-in from both of them, per #412. |
github-actions bot
added a commit
that referenced
this pull request
Dec 20, 2022
SHA: cdaece1 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forbids top-level auctions from both having their own buyers and having component auctions, as discussed in issue #412.
This is a rare case where we're proposing removing support from a feature present in the current field trial - I'm hoping we can just announce the change, give folks a couple weeks to raise concerns, and then let the change percolate through to stable as it makes it from channel to channel. We could do something more thorough (measure usage, add deprecations, etc), but since it's still an experimental feature, hopefully that won't be needed.