Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/gui #9
base: main
Are you sure you want to change the base?
Dev/gui #9
Changes from 3 commits
c034d64
a184ff0
a2551ab
05dcbc4
2ee159c
b364819
2f64efc
c4ac809
e27eb09
8823011
396740c
83939be
a68f5ea
609cb84
4a6eb9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not clear to me what happened with this file so I don't know why it's showing up in this commit, but I do recall regretting the fact that it was written (not by me). I'm guessing it's just a file rename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this node just needed a bit of tweaking since there was a missing paren. Also note that 'Duration' doesn't operate in Hz, so if you want this called at 4 hz you have to give it a duration of 1/4. Also, although the timer takes in a parameter, it's there to denote event information (expected duration vs. actual duration). Finally, there were 3 different things called 'publisher', so I just removed the unused import and renamed the class variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better practice is to use singular imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also good practice would be to sort these a tad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global scoped constant variables that are lowercase (instead of conventional ALL_CAPS)? Alternatively, since you know the goal is for this to be full-screen, you could just collect those resolution values and go from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this import here and not up at the top? Also, you may need to make use of
rospy.myargv
if you plan on running this as a node.