Feat/add python 3.13 support #384
Conversation
WalkthroughThe pull request updates the CI configuration by removing the Changes
Sequence Diagram(s)sequenceDiagram
participant Repo as Repository
participant CI as CI Runner
participant PY as Python Environment
Repo->>CI: Trigger CI Workflow
CI-->>CI: (Pre-commit step removed)
CI->>PY: Set up Python environment (version: "3.13")
PY-->>CI: Environment initialised
CI->>Repo: Return build/test results
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #384 +/- ##
===========================================
+ Coverage 78.67% 78.71% +0.03%
===========================================
Files 33 33
Lines 2786 2786
===========================================
+ Hits 2192 2193 +1
+ Misses 594 593 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: test (3.12, windows-latest)
- GitHub Check: test (3.12, macos-latest)
- GitHub Check: test (3.12, ubuntu-latest)
- GitHub Check: test (3.11, windows-latest)
- GitHub Check: test (3.11, macos-latest)
- GitHub Check: test (3.11, ubuntu-latest)
- GitHub Check: test (3.10, windows-latest)
- GitHub Check: test (3.10, macos-latest)
- GitHub Check: test (3.10, ubuntu-latest)
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
12-14: Observation: Removal of Pre-commit ActionThe CI configuration no longer includes a step that used the
pre-commit/action@v3.0.1. Please confirm that this omission is intentional, as removing this step could bypass important pre-commit checks previously enforced in the pipeline.
.github/workflows/ci.yml
Outdated
| python-version: ["3.10", "3.11", "3.12", "3,13"] | ||
| os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
Critical Issue: Incorrect Python Version Entry
The Python version matrix contains a typographical error: "3,13" is used instead of the correct "3.13". This error could lead to failures when setting up the Python environment during CI runs.
Please update the line as follows:
- python-version: ["3.10", "3.11", "3.12", "3,13"]
+ python-version: ["3.10", "3.11", "3.12", "3.13"]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| python-version: ["3.10", "3.11", "3.12", "3,13"] | |
| os: [ubuntu-latest, macos-latest, windows-latest] | |
| python-version: ["3.10", "3.11", "3.12", "3.13"] | |
| os: [ubuntu-latest, macos-latest, windows-latest] |
AntObi
added
python
Add Python 3.13 support for SMACT
Description
Python 3.13 support will require
spglib>=2.6.0, see spglib/spglib#544Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Reviewers
@mention individuals who you specifically want to involve in the discussion for this pull request and mention why they are needed in the discussion/why they are needed to review the pull request.
Checklist
Summary by CodeRabbit
qajob, streamlining the testing process.