Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add python 3.13 support #384

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Feat/add python 3.13 support #384

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24127c8
Add python 3.13 to python-version mattrix
AntObi Mar 5, 2025
485105c
Remove pre-commit from workflow as pre-commit.ci is now used
AntObi Mar 5, 2025
2fa4eea
Correct mistake on python version
AntObi Mar 5, 2025
78f6bd5
Remove qa step
AntObi Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pre-commit/action@v3.0.1

test:
needs: qa
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.11", "3.12"]
python-version: ["3.10", "3.11", "3.12", "3,13"]
os: [ubuntu-latest, macos-latest, windows-latest]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical Issue: Incorrect Python Version Entry

The Python version matrix contains a typographical error: "3,13" is used instead of the correct "3.13". This error could lead to failures when setting up the Python environment during CI runs.

Please update the line as follows:

-        python-version: ["3.10", "3.11", "3.12", "3,13"]
+        python-version: ["3.10", "3.11", "3.12", "3.13"]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
python-version: ["3.10", "3.11", "3.12", "3,13"]
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.10", "3.11", "3.12", "3.13"]
os: [ubuntu-latest, macos-latest, windows-latest]


runs-on: ${{matrix.os}}
Expand Down
Loading