Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Largo Facebook Widget lacks a title field, but the form has a "Title URL" field in the settings page. #1739

Closed
benlk opened this issue Jul 9, 2019 · 3 comments · Fixed by #1840

Comments

@benlk
Copy link
Collaborator

benlk commented Jul 9, 2019

Following up on #1736 for #1717, the decision was made to check all Largo widgets to see if they output the widget title safely.

No widget title is output in the widget, and the widget has no field to save the widget title.

https://github.com/INN/largo/blob/aa45901f61d1b8840512e603780b29853f3bbf80/inc/widgets/largo-facebook.php#L22-L38

But the widget does display Largo's "Widget Title Link" field:
Screen Shot 2019-07-09 at 16 38 15

@benlk
Copy link
Collaborator Author

benlk commented Jul 9, 2019

Should this widget have a title field? If so, add one.

@joshdarby
Copy link
Collaborator

@benlk Should we wrap the Twitter widget into this issue also? The same thing is happening with it.

@benlk
Copy link
Collaborator Author

benlk commented Jul 9, 2019

I'd create a separate issue for it, but there's no reason they couldn't be addressed in the same PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants