Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Largo Twitter Widget lacks a title field, but the form has a "Title URL" field in the settings page. #1740

Closed
joshdarby opened this issue Jul 9, 2019 · 0 comments · Fixed by #1840
Closed

Largo Twitter Widget lacks a title field, but the form has a "Title URL" field in the settings page. #1740

joshdarby opened this issue Jul 9, 2019 · 0 comments · Fixed by #1840
Labels
Estimate: < 2 Hours good for beginners hacktoberfest help wanted type: bug

Comments

@joshdarby
Copy link
Collaborator

joshdarby commented Jul 9, 2019 •
edited
Loading

Same as #1739, but the Twitter widget.

Following up on #1736 for #1717, the decision was made to check all Largo widgets to see if they output the widget title safely.

No widget title is output in the widget, and the widget has no field to save the widget title.

https://github.com/INN/largo/blob/aa45901f61d1b8840512e603780b29853f3bbf80/inc/widgets/largo-twitter.php#L22-L73

But the widget does display Largo's "Widget Title Link" field:
Screen Shot 2019-07-09 at 4 44 18 PM
@benlk benlk mentioned this issue Jul 9, 2019
Merged
1 task
seanchayes added a commit to seanchayes/largo that referenced this issue Oct 18, 2019
@seanchayes
Relocating title field in widget admin, escaping title text, includin…
9c13f7e 
…g same approach for Twitter widget in issue WPBuddy#1740
@seanchayes seanchayes mentioned this issue Oct 18, 2019
Closed
4 tasks
@benlk benlk mentioned this issue Dec 20, 2019
Merged
4 tasks
@joshdarby joshdarby linked a pull request Apr 9, 2021 that will close this issue
Widget titles (and other improvements) for Twitter and Facebook widgets #1840
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimate: < 2 Hours good for beginners hacktoberfest help wanted type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Widget titles (and other improvements) for Twitter and Facebook widgets WPBuddy/largo
2 participants
@benlk @joshdarby