Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes the following changes:
The title field is added to the widget in admin for both the Facebook and Twitter widgets and when not empty the title is displayed. If a corresponding title link is entered into the widget this is used as the title link.
I did add escaping to the title text in the
largo_add_link_to_widget_title
function but understand that affects all the widgets. So, happy to help test or remove as appropriate. I tested the Taxonomy and Tax list widgets with no adverse affects.Apologies for the occasional whitespace change.
Why
This PR applies consistent behavior for this widget
For #1739 and #1740
Testing/Questions
Features that this PR affects:
largo_add_link_to_widget_title
callback onwidget_title
Questions that need to be answered before merging:
Steps to test this PR:
Additional information
INN Member/Labs Client requesting: (if applicable)