Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new animation option type #2202

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Use the new animation option type #2202

merged 1 commit into from
Mar 13, 2024

Conversation

ammen99
Copy link
Member

@ammen99 ammen99 commented Mar 12, 2024

This PR updates the plugins to use the new animation option type from wf-config.

Note that there are no breaking changes, because the old way to use animations (integer duration option) still works.
Plugins which want to be more configurable have to update their code to use the new option type (which is very simple in most cases).

In any case, this change makes it possible to be a bit more explicit in the config file, for example 200ms or 2.5s, both are accepted.
For backwards compatibility, the user can also just write a simple number, 200 as before, which is interpreted as 200ms.

Also, the animation easing function is now configurable if one uses the full format. For example, 200ms linear or 200ms circle. The default easing function was and remains circle, but sometimes sigmoid or linear might look better. Also for fun one can use easeOutElastic. We can also add more functions to wf-config, if desired.

@ammen99 ammen99 marked this pull request as ready for review March 13, 2024 12:36
@ammen99 ammen99 merged commit 3aa8c3f into master Mar 13, 2024
8 checks passed
@ammen99 ammen99 deleted the animation-types branch March 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant