Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wcm can not change animation duration anymore. #79

Closed
mark-herbert42 opened this issue Mar 31, 2024 · 4 comments · Fixed by #80
Closed

wcm can not change animation duration anymore. #79

mark-herbert42 opened this issue Mar 31, 2024 · 4 comments · Fixed by #80

Comments

@mark-herbert42
Copy link

Most likely it happened after teh commit changing the duration value from number to a string
WayfireWM/wayfire#2202

@soreau
Copy link
Member

soreau commented Apr 1, 2024

This is a known problem since durations now have optional easing types. Here is a patch to fix it but it's not completed yet. Once it is, we can make a new release of wcm.

@marcusbritanicus
Copy link

Just ran into this issue... The patch does not seem to apply.

❯ curl https://termbin.com/kd1a | git apply
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7791  100  7791    0     0   3072      0  0:00:02  0:00:02 --:--:--  3073
error: patch failed: src/metadata.cpp:51
error: src/metadata.cpp: patch does not apply

Am I doing something wrong?

@mark-herbert42
Copy link
Author

patch is not awailable anymore. I was thinking to rebase and give it a try but file not found anynore

@soreau
Copy link
Member

soreau commented Jun 16, 2024

Can anyone interested test this patch? Looking for proper functionality for 1) Set duration 2) Set easing 3) Reset to Default button 4) Restart wcm and ensure settings expected settings are populated.

soreau added a commit that referenced this issue Jun 16, 2024
soreau added a commit that referenced this issue Jun 24, 2024
soreau added a commit that referenced this issue Jun 24, 2024
@soreau soreau closed this as completed in 84b1893 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants