Smallpatches #5460
Merged
Smallpatches #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the item type is a required setting, the user can't toggle between single and multi-selection. That is multiselection and required are incompatible with each other. But the only instance of that is the item type trigger, so instead force the trigger to multi-selection. Fixes: WeakAuras#5443
Unclear when we broke that. Fixes: WeakAuras#5450
mrbuds
reviewed
Oct 3, 2024
| @@ -3677,7 +3677,7 @@ Private.event_prototypes = { | |||
| if powerType == 4 then | |||
| table.insert(ret, [[ | |||
| local power = GetComboPoints(unit, unit .. '-target') | |||
| local total = math.max(1, UnitPowerMax(unit, 14)) | |||
| local total = math.max(1, UnitPowerMax(unit, 4)) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
🤔 what was powertype 14 before it was obsoleted?
mrbuds
reviewed
Oct 3, 2024
| @@ -511,6 +511,7 @@ templates.class.WARRIOR = { | |||
| { spell = 7384, type = "ability", charges = true, buff = true, overlayGlow = true, requiresTarget = true, talent = 112123 }, -- Overpower | |||
| { spell = 12294, type = "ability", overlayGlow = true, requiresTarget = true, talent = 112122 }, -- Mortal Strike | |||
| { spell = 12323, type = "ability", debuff = true, talent = 112210 }, -- Piercing Howl | |||
| { spell = 167105, type = "ability", requiresTarget = true }, -- Colossus Smash | |||
There was a problem hiding this comment.
can you move this after Execute and add , debuff = true?
mrbuds
approved these changes
Oct 3, 2024
* Set Progress Source settings to default collapsed, it's usually not something people will want to touch. * Set Position settings to default collapsed. This is a bit more controversial, but imho most editing of auras does not involve those. * Set Sub Element settings to default collapsed.
InfusOnWoW
force-pushed
the
smallpatches
branch
from
7ac2b5b
to
2dba7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.