Port test/passes/d* to lit #4008
Conversation
|
|
||
| (module | ||
| (memory 10) | ||
| (type $ii (func (param i32 i32))) |
There was a problem hiding this comment.
Where is the output for this file? E.g. the first function $call-me has no CHECKs, nor the second.
There was a problem hiding this comment.
Not sure why the checks were missing for this file. I just regenerated all these tests now and it looks fine.
| ) | ||
| (func $bar (result i32) | ||
| (unreachable) | ||
| ) |
There was a problem hiding this comment.
The function $bar is removed by this optimization, but the CHECKs don't make that obvious. Even just the fact that it has no CHECKs isn't quite enough, as the function after it, "export", also has no CHECKs - its CHECKs actually appear after the module.
Could we emit a CHECK that says a function no longer exist?
Separately, adding a $ name for the final function, and not just an export name, would help things like this.
But skip duplicate elimination tests until we can consider better inserting checks for removed items.
|
Ok I removed all duplicate elimination tests from this to sidestep the issues with them for now. Once all the straightforward tests are ported we can budget some time to do a good job of porting the rest. |
2 participants
No description provided.