Replace 'event' with 'tag' in explainer #161

aheejin · 2021-06-11T21:30:43Z

It was suggested to change the term 'event' to 'tag' to reference the
section name and the entries within the section. The suggested reasons
were they can be used something other than events in future, and the
term event can be confusing with other concepts on the web.

Closes #159.

It was suggested to change the term 'event' to 'tag' to reference the section name and the entries within the section. The suggested reasons were they can be used something other than events in future, and the term event can be confusing with other concepts on the web. Closes WebAssembly#159.

proposals/exception-handling/Exceptions.md

tlively · 2021-06-12T03:49:54Z

proposals/exception-handling/Exceptions.md

 In general, an event handler allows one to process an event generated by a block
 of code. Events suspend the current execution and look for a corresponding event


"event" should be replaced with "exception" wherever it is referring to a runtime exception, "exception tag" whenever it is referring to the static exception type, and just "tag" whenever it is referring to potential future contents of the tag section.

Similarly, it would be good to replace instances of "exception" with "exception tag" when they are referring to the static exception declaration.

Thanks for the suggestion; I think the distinction makes the text a lot clearer. Fixed many parts of the existing text.

proposals/exception-handling/Exceptions.md

tlively · 2021-06-12T03:57:38Z

proposals/exception-handling/Exceptions.md

+A new `tag` section is introduced. If included, it must appear immediately after
+the memory section.


It might be worth adding the caveat that custom sections can appear in between these two sections. Alternatively, we could say that the tag section is ordered between the memory section and the global section.

Edit: actually, we already say that below, so maybe this sentence isn't necessary?

Thanks; removed.

proposals/exception-handling/Exceptions.md

tlively · 2021-06-12T04:02:42Z

proposals/exception-handling/Exceptions.md

-| count | `varuint32` | count of the number of event to follow |
-| type | `event_type*` | The definitions of the event types |
+| count | `varuint32` | count of the number of tags to follow |
+| type | `tag_type*` | The definitions of the tag types |


Is tag_type defined anywhere?

While creating this PR, I found multiple occurrences that we had missed when we had replaced 'exception' with 'event' before, and I tried to replace 'event' with 'tag' in this PR, so I missed those remaining 'exception's.. It was written as exception_type. I changed it to tag_type now.

Co-authored-by: Thomas Lively <7121787+tlively@users.noreply.github.com>

rossberg

Looks good, mostly nits.

proposals/exception-handling/Exceptions.md

rossberg · 2021-06-15T12:35:15Z

proposals/exception-handling/Exceptions.md


 | Field | Type | Description |
 |-------|------|-------------|
-| `attribute` | `varuint32` | The attribute of an exception. |
+| `attribute` | `varuint32` | The attribute of a tag. |


Obviously a separate issue, but I'm just noticing this while I'm here: I'd conservatively make this a uint8 for the time being, since we do not know yet how exactly this is gonna be used in the future, and a zero uint8 is still forward compatible with varuint32. That's what we did in other places anyway.

I can do that as a followup PR. But why uint8 better than varuint32 here?

It's both more conservative and faster to decode. No reason to bother with allowing multibyte representations of 0 before we even know that we'll need them.

Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>

We recently decided to change 'event' to 'tag', and to 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161

We recently decided to change 'event' to 'tag', and 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161 Reviewed By: tlively Differential Revision: https://reviews.llvm.org/D104423

This changes the encoding of the `attribute` field, which is preserved for future use, from `varuint32` to `uint8`. `uint8` is simpler to encode/decode and this attribute is not likely to need `varuint32` range even in future. Suggested in WebAssembly#161 (comment).

We recently decided to change 'event' to 'tag', and to 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161

We recently decided to change 'event' to 'tag', and 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161

This changes the encoding of the `attribute` field, which is preserved for future use, from `varuint32` to `uint8`. `uint8` is simpler to encode/decode and this attribute is not likely to need `varuint32` range even in future. Suggested in #161 (comment).

We recently decided to change 'event' to 'tag', and 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161

The exception handling proposal spec was recently changed to rename the event section to the tag section, in order to use a clearer name that conflicts with fewer things in the web context: WebAssembly/exception-handling#161

#291) * Update wabt test submodule to latest * Update wasm-encoder linking tests for latest wabt A recent PR to wabt changed the printing slightly for these test cases: WebAssembly/wabt#1669 * Rename "events" to "tags" for exception handling The exception handling proposal spec was recently changed to rename the event section to the tag section, in order to use a clearer name that conflicts with fewer things in the web context: WebAssembly/exception-handling#161

As per WebAssembly#161

We recently decided to change 'event' to 'tag', and 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161 Reviewed By: tlively Differential Revision: https://reviews.llvm.org/D104423

aheejin requested review from takikawa, RossTate, fgmccabe, thibaudmichaud, rossberg, lars-t-hansen, tlively and ioannad June 11, 2021 21:30

tlively reviewed Jun 12, 2021

View reviewed changes

takikawa mentioned this pull request Jun 12, 2021

[js-api] Add description of interface additions to overview document #154

Merged

aheejin and others added 2 commits June 15, 2021 00:20

Apply suggestions from code review

ff98af9

Co-authored-by: Thomas Lively <7121787+tlively@users.noreply.github.com>

Fixes

681306e

rossberg approved these changes Jun 15, 2021

View reviewed changes

aheejin and others added 2 commits June 15, 2021 13:45

Apply suggestions from code review

f12debd

Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>

80 cols

895df8f

takikawa approved these changes Jun 16, 2021

View reviewed changes

This was referenced Jun 17, 2021

[EH] Replace event with tag WebAssembly/binaryen#3937

Merged

Event vs. exception? #159

Closed

aheejin merged commit 5aa690d into WebAssembly:master Jun 18, 2021

aheejin deleted the tag_section branch June 18, 2021 02:59

aheejin mentioned this pull request Jun 18, 2021

Make attribute's encoding uint8 #162

Merged

aheejin mentioned this pull request Jun 22, 2021

[EH] Replace event with tag WebAssembly/wabt#1678

Merged

aheejin mentioned this pull request Jun 22, 2021

Advance to Phase 3? #163

Closed

takikawa mentioned this pull request Jun 22, 2021

Handle the rename of "events" to "tags" in exception handling proposal bytecodealliance/wasm-tools#291

Merged

ioannad added a commit to ioannad/exception-handling that referenced this pull request Jun 25, 2021

Renamed Exceptions to Tags

f9abf80

As per WebAssembly#161

ioannad added a commit to ioannad/exception-handling that referenced this pull request Jun 25, 2021

Renamed Exceptions to Tags

8cfa1b6

As per WebAssembly#161

Horcrux7 mentioned this pull request Jul 16, 2021

wat2wasm: function variable resolution broken WebAssembly/wabt#1689

Closed

Horcrux7 added a commit to i-net-software/JWebAssembly that referenced this pull request Aug 29, 2021

[EH] Replace event with tag WebAssembly/exception-handling#161

1bfe16b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace 'event' with 'tag' in explainer #161

Replace 'event' with 'tag' in explainer #161

aheejin commented Jun 11, 2021

tlively Jun 12, 2021

aheejin Jun 15, 2021

tlively Jun 12, 2021

aheejin Jun 15, 2021

tlively Jun 12, 2021

aheejin Jun 15, 2021

rossberg left a comment

rossberg Jun 15, 2021

aheejin Jun 15, 2021

rossberg Jun 16, 2021

		In general, an event handler allows one to process an event generated by a block
		of code. Events suspend the current execution and look for a corresponding event

		A new `tag` section is introduced. If included, it must appear immediately after
		the memory section.

Replace 'event' with 'tag' in explainer #161

Replace 'event' with 'tag' in explainer #161

Conversation

aheejin commented Jun 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rossberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment