Make attribute's encoding uint8 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the encoding of the `attribute` field, which is preserved for future use, from `varuint32` to `uint8`. `uint8` is simpler to encode/decode and this attribute is not likely to need `varuint32` range even in future. Suggested in WebAssembly#161 (comment).
aheejin
changed the title
aheejin
added a commit
to llvm/llvm-project
that referenced
this pull request
Jun 22, 2021
This changes the encoding of the `attribute` field, which currently only contains the value `0` denoting this tag is for an exception, from `varuint32` to `uint8`. This field is effectively unused at the moment and reserved for future use, and it is not likely to need `varuint32` even in future. See WebAssembly/exception-handling#162. This does not change any encoded binaries because `0` is encoded in the same way both in `varuint32` and `uint8`. Reviewed By: tlively Differential Revision: https://reviews.llvm.org/D104571
aheejin
added a commit
to aheejin/binaryen
that referenced
this pull request
Jun 22, 2021
This changes the encoding of the `attribute` field, which currently only contains the value `0` denoting this tag is for an exception, from `varuint32` to `uint8`. This field is effectively unused at the moment and reserved for future use, and it is not likely to need `varuint32` even in future. See WebAssembly/exception-handling#162. This does not change any encoded binaries because `0` is encoded in the same way both in `varuint32` and `uint8`.
rossberg
approved these changes
Jun 22, 2021
aheejin
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Jun 22, 2021
This changes the encoding of the `attribute` field, which currently only contains the value `0` denoting this tag is for an exception, from `varuint32` to `uint8`. This field is effectively unused at the moment and reserved for future use, and it is not likely to need `varuint32` even in future. See WebAssembly/exception-handling#162. This does not change any encoded binaries because `0` is encoded in the same way both in `varuint32` and `uint8`.
Closed
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Jun 26, 2021
This changes the encoding of the `attribute` field, which currently only contains the value `0` denoting this tag is for an exception, from `varuint32` to `uint8`. This field is effectively unused at the moment and reserved for future use, and it is not likely to need `varuint32` even in future. See WebAssembly/exception-handling#162. This does not change any encoded binaries because `0` is encoded in the same way both in `varuint32` and `uint8`.
aheejin
added a commit
to WebAssembly/wabt
that referenced
this pull request
Jun 29, 2021
This changes the encoding of the `attribute` field, which currently only contains the value `0` denoting this tag is for an exception, from `varuint32` to `uint8`. This field is effectively unused at the moment and reserved for future use, and it is not likely to need `varuint32` even in future. See WebAssembly/exception-handling#162. This does not change any encoded binaries because `0` is encoded in the same way both in `varuint32` and `uint8`.
takikawa
added a commit
to takikawa/wasm-tools
that referenced
this pull request
Aug 21, 2021
To match this spec change: WebAssembly/exception-handling#162
alexcrichton
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Aug 21, 2021
To match this spec change: WebAssembly/exception-handling#162
arichardson
pushed a commit
to arichardson/llvm-project
that referenced
this pull request
Sep 13, 2021
This changes the encoding of the `attribute` field, which currently only contains the value `0` denoting this tag is for an exception, from `varuint32` to `uint8`. This field is effectively unused at the moment and reserved for future use, and it is not likely to need `varuint32` even in future. See WebAssembly/exception-handling#162. This does not change any encoded binaries because `0` is encoded in the same way both in `varuint32` and `uint8`. Reviewed By: tlively Differential Revision: https://reviews.llvm.org/D104571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the encoding of the
attributefield, which is preservedfor future use, from
varuint32touint8.uint8is simpler toencode/decode and this attribute is not likely to need
varuint32rangeeven in future.
Suggested in
#161 (comment).