[test/interpreter] Rounding edge cases for float text literals #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
changed the title
binji
approved these changes
May 28, 2019
test/core/const.wast
Outdated
| @@ -135,3 +141,300 @@ | |||
| (module quote "(func (f64.const -269653970229347356221791135597556535197105851288767494898376215204735891170042808140884337949150317257310688430271573696351481990334196274152701320055306275479074865864826923114368235135583993416113802762682700913456874855354834422248712838998185022412196739306217084753107265771378949821875606039276187287552) drop)") | |||
| "constant out of range" | |||
| ) | |||
|
|
|||
| ;; NaNs | |||
There was a problem hiding this comment.
These seem similar to tests in float_literals.wast and int_literals.wast -- is it testing a different case?
| (func (export "f64") (param f64) (result f64) (local.get 0)) | ||
| ) | ||
|
|
||
| ;; f32, small exponent |
There was a problem hiding this comment.
We should probably have some decimal test cases here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #809 and other double rounding edge cases.
Adds various tests for rounding on f32 and f64 literals.
Adds a gross hack to the interpreter to detect and correct double rounding without having to reimplement float parsing.