Update MacOS-15 ci job building against llvm 15.0.7 to llvm 16.0.0 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Feb 3, 2025
| @@ -25,7 +25,7 @@ jobs: | |||
| llvm_asset_suffix: x86_64-linux-gnu-ubuntu-18.04 | |||
| enable_pic: true | |||
| - os: macos-15 | |||
| clang_version: 15.0.7 | |||
| clang_version: 16.0.0 | |||
There was a problem hiding this comment.
I think the reason for the different version here is a deliberate choice to make sure wasi-libc is compatible with different versions of llvm. If you want to propose dropping support for a certain older versions then please open a bug and we can discuss it there.
There was a problem hiding this comment.
It wasn't so much about dropping support. I just didn't understand why it doesn't match the llvm version targeted for other operating systems (e.g. other operating systems target 10.0.0 and 16.0.0, and not 10.0.0 and 15.0.7 like the MacOS jobs do). If its deliberate that it is different then I will close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ci jobs are either building against 10.0.0 or 16.0.0 except the MacOS job which builds against 15.0.7 . The PR updates the MacOS so it is consistent with the llvms used on the other operating systems.