Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS-15 ci job building against llvm 15.0.7 to llvm 16.0.0 #570

Closed
wants to merge 1 commit into from
Closed

Update MacOS-15 ci job building against llvm 15.0.7 to llvm 16.0.0 #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
llvm_asset_suffix: x86_64-linux-gnu-ubuntu-18.04
enable_pic: true
- os: macos-15
clang_version: 15.0.7
clang_version: 16.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason for the different version here is a deliberate choice to make sure wasi-libc is compatible with different versions of llvm. If you want to propose dropping support for a certain older versions then please open a bug and we can discuss it there.

Copy link
Contributor Author

@mcbarton mcbarton Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't so much about dropping support. I just didn't understand why it doesn't match the llvm version targeted for other operating systems (e.g. other operating systems target 10.0.0 and 16.0.0, and not 10.0.0 and 15.0.7 like the MacOS jobs do). If its deliberate that it is different then I will close the PR.

llvm_asset_suffix: x86_64-apple-darwin21.0
- os: windows-2025
clang_version: 16.0.0
Expand Down
Loading