Fix WebAudio/web-audio-api-v2#13: User-selectable render size #2369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft of the changes for user-selectable render size. I'm kind of stuck right now because I don't know how to handle adding the new Also see speced/bikeshed#2109 |
hoch
approved these changes
Jul 16, 2021
| Changes Since Recommendation of 17 Jun 2021 | ||
| </h3> | ||
| * <a href="https://github.com/WebAudio/web-audio-api-v2/issue/13">V2 Issue 13</a>: User-selectable render size | ||
| <div id="change-list-a13"> |
There was a problem hiding this comment.
Just curious: what's this div for?
| </span> | ||
| Categories for user-selectable render size. | ||
| <div class="amendment-buttons"> | ||
| Buttons here |
There was a problem hiding this comment.
I guess this "Buttons here" text will be replaced by scripts?
| let text = ""; | ||
| if (changeNum > 1) { | ||
| // Add "previous" button, only if there is a previous change. | ||
| text += "<button onclick='location.href="; |
There was a problem hiding this comment.
nit: I think it's better to use string literal than concatenation.
|
|
||
| if (document.getElementById(changeID + "-" + (changeNum + 1))) { | ||
| // Add "next" button only if there is a next change | ||
| text += "<button onclick='location.href="; |
|
I am not sure if someone can take over this draft. If not, we should close and revisit later. |
|
Closing this in favor of #2469. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff