-
Notifications
You must be signed in to change notification settings - Fork 171
Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext #2469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It actually fixes #2450, I got confused because this got moved from the old v2 repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have a few comments.
The direction of this work looks great, but we (@hoch and @padenot representing Chrome and FireFox respectively) agreed that we don't have capacity to finish the actual implementation of this feature in 2022. We believe bringing the spec change when we don't have any implementations support it will confuse developers, so we decided to put this PR on hold until we have a plan for the actual engineering work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits.
8badf58
to
d37ffcb
Compare
I've rebased this on top of the current |
… or OfflineAudioContext
d37ffcb
to
c3cbd7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM, but with two nits.
Thanks for working on this, @padenot! |
This fixes #13.
Without the heavy markup for now, this will come later.
This largely implements what was discussed.
Preview | Diff