Skip to content

Conversation

padenot
Copy link
Member

@padenot padenot commented Feb 8, 2022

This fixes #13.

Without the heavy markup for now, this will come later.

This largely implements what was discussed.


Preview | Diff

@padenot padenot requested a review from hoch February 8, 2022 13:54
@padenot padenot self-assigned this Feb 8, 2022
@padenot
Copy link
Member Author

padenot commented Feb 8, 2022

It actually fixes #2450, I got confused because this got moved from the old v2 repo.

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have a few comments.

@hoch
Copy link
Member

hoch commented Mar 15, 2022

The direction of this work looks great, but we (@hoch and @padenot representing Chrome and FireFox respectively) agreed that we don't have capacity to finish the actual implementation of this feature in 2022. We believe bringing the spec change when we don't have any implementations support it will confuse developers, so we decided to put this PR on hold until we have a plan for the actual engineering work.

@hoch hoch changed the title Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext [On Hold] Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext Mar 15, 2022
@hoch hoch added Priority: Urgent WG charter deliverables; "need to have". https://speced.github.io/spec-maintenance/about/ and removed recharter-deliverables Priority: Urgent WG charter deliverables; "need to have". https://speced.github.io/spec-maintenance/about/ labels Sep 14, 2022
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

@hoch hoch changed the title [On Hold] Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext Sep 11, 2023
@padenot padenot force-pushed the 13-user-selectable-render-size branch from 8badf58 to d37ffcb Compare September 21, 2023 12:16
@padenot
Copy link
Member Author

padenot commented Sep 21, 2023

I've rebased this on top of the current main branch. I'll add the markup in a separate commit for clarity, the only functional changes are in the first commit.

@padenot padenot force-pushed the 13-user-selectable-render-size branch from d37ffcb to c3cbd7a Compare September 21, 2023 12:25
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, but with two nits.

@padenot padenot merged commit 0c5f2df into main Sep 22, 2023
@hoch
Copy link
Member

hoch commented Sep 22, 2023

Thanks for working on this, @padenot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants