STM Backend support #57
Conversation
| @@ -15,12 +15,16 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_GRID_LAYOUT PRIVATE ON) | |||
| WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET PUBLIC ON) | |||
| WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON) | |||
| WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON) | |||
| WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PRIVATE ON) | |||
There was a problem hiding this comment.
The changes in this file seem unrelated to the patch. Please make sure you base your branch on top of current WPE master.
There was a problem hiding this comment.
Addressed by rebasing files.
| ) | ||
| list(APPEND WPE_SOURCES | ||
| Source/Graphics/STM/RenderingBackendSTM.cpp | ||
| Source/Graphics/RenderingBackend.cpp |
There was a problem hiding this comment.
I don't think you need this line, the file is already included in the list on line 114.
|
@zdobersek |
|
Looks OK, thanks for the updates. |
|
Thanks @zdobersek |
|
This breaks non-Wayland nexus builds:
Shouldn't inclusion of the header files for each backend be conditional on the associated backend being enabled? |
|
@armcc added a guard in the header file in master |
|
Thanks @albertd |
|
See #79 for the port on new WPE |
This request addresses the review comments of pull -#40