Wayland-egl backend (previously named STM) #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The STM is just a generic backend relying on wayland-egl, with no code specific to STM chipsets.
This backend creates wayland-egl window from the renderer process. The view part only acks buffer to send frame complete events. This is based on the STM implementation in WPE-old, and reuses the Wayland::Display class initially implemented for BCMNexusWL. Input support is not implemented yet. This closes WebPlatformForEmbedded#65.
Merged
|
The code is pretty straight-forward, no complaints there. I don't know about the name though -- maybe it should be more clear that this is a special case, where the UIProcess doesn't act as a normal client of the compositor but it's instead the WebProcess that connects to it. I don't know what STM stood for though, and I'm not terribly against WAYLAND_EGL. If you think there's a more descriptive name, feel free to switch to that. |
|
STM probably stood for STMicroelectronics, they previously had a wide range of set-top-box products. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backend creates wayland-egl window from the renderer process.
The view part only acks buffer to send frame complete events.
This is based on the STM implementation in WPE-old, and reuses the
Wayland::Display class initially implemented for BCMNexusWL.
Input support is not implemented yet.
This closes #65.